From: sbaugh@catern.com
To: Eli Zaretskii <eliz@gnu.org>
Cc: Spencer Baugh <sbaugh@janestreet.com>, 63096@debbugs.gnu.org
Subject: bug#63096: [PATCH] Note that Emacs pauses when handling sentinel errors
Date: Tue, 02 May 2023 14:46:22 +0000 (UTC) [thread overview]
Message-ID: <878re6rdtu.fsf@catern.com> (raw)
In-Reply-To: <838redubty.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Apr 2023 08:35:21 +0300")
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Spencer Baugh <sbaugh@janestreet.com>
>> Date: Wed, 26 Apr 2023 18:04:05 -0400
>>
>> For emacs-29, since this variable is new in Emacs 29.
>
> Thanks.
>
>> diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi
>> index 50e67475d8e..39d1ee64e43 100644
>> --- a/doc/lispref/processes.texi
>> +++ b/doc/lispref/processes.texi
>> @@ -2159,7 +2159,9 @@ Sentinels
>> programs was running when the sentinel was started. However, if
>> @code{debug-on-error} is non-@code{nil}, errors are not caught.
>> This makes it possible to use the Lisp debugger to debug the
>> -sentinel. @xref{Debugger}.
>> +sentinel. @xref{Debugger}. Additionally, Emacs pauses for
>
> Why "Additionally"? What you are describing is not in addition to
> what was described before that.
>
>> +@var{process-error-pause-time} seconds so that the user sees the
>> +error. @xref{Asynchronous Processes}
>
> If we are mentioning this variable here, let's also mention it where
> filter functions are described, since it is also relevant to those.
OK, fixed.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Note-that-Emacs-pauses-when-handling-sentinel-errors.patch --]
[-- Type: text/x-patch, Size: 1939 bytes --]
From ce5909f81485d0cfb0e4622251816e83ef422a5c Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@catern.com>
Date: Tue, 2 May 2023 10:42:11 -0400
Subject: [PATCH] Note that Emacs pauses when handling sentinel errors
Noting this behavior and variable here makes it easier to understand
the behavior of Emacs when a sentinel has an error.
* doc/lispref/processes.texi (Filter Functions): Note that Emacs
pauses when handling sentinel errors.
(Sentinels): Note that Emacs pauses when handling sentinel errors.
---
doc/lispref/processes.texi | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi
index 50e67475d8e..f55ed7887d2 100644
--- a/doc/lispref/processes.texi
+++ b/doc/lispref/processes.texi
@@ -1755,7 +1755,9 @@ Filter Functions
program was running when the filter function was started. However, if
@code{debug-on-error} is non-@code{nil}, errors are not caught.
This makes it possible to use the Lisp debugger to debug filter
-functions. @xref{Debugger}.
+functions. @xref{Debugger}. If an error is caught, Emacs pauses for
+@var{process-error-pause-time} seconds so that the user sees the
+error. @xref{Asynchronous Processes}
Many filter functions sometimes (or always) insert the output in the
process's buffer, mimicking the actions of the default filter.
@@ -2159,7 +2161,9 @@ Sentinels
programs was running when the sentinel was started. However, if
@code{debug-on-error} is non-@code{nil}, errors are not caught.
This makes it possible to use the Lisp debugger to debug the
-sentinel. @xref{Debugger}.
+sentinel. @xref{Debugger}. If an error is caught, Emacs pauses for
+@var{process-error-pause-time} seconds so that the user sees the
+error. @xref{Asynchronous Processes}
While a sentinel is running, the process sentinel is temporarily
set to @code{nil} so that the sentinel won't run recursively.
--
2.38.0
next prev parent reply other threads:[~2023-05-02 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 22:04 bug#63096: [PATCH] Note that Emacs pauses when handling sentinel errors Spencer Baugh
2023-04-27 5:35 ` Eli Zaretskii
2023-05-02 14:46 ` sbaugh [this message]
2023-05-02 15:01 ` Robert Pluim
2023-05-02 15:38 ` sbaugh
2023-05-02 17:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878re6rdtu.fsf@catern.com \
--to=sbaugh@catern.com \
--cc=63096@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).