From: Andrew Cohen <cohen@bu.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrew Cohen <cohen@bu.edu>,
64117@debbugs.gnu.org, eric@ericabrahamsen.net,
jschmidt4gnu@vodafonemail.de, cohen@andy.bu.edu
Subject: bug#64117: 28.2; "gnus-request-set-mark: Buffer is read-only" when exiting agentized, unplugged summary buffer
Date: Wed, 21 Jun 2023 22:22:37 +0800 [thread overview]
Message-ID: <878rccao9e.fsf@ust.hk> (raw)
In-Reply-To: <83mt0s52du.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 21 Jun 2023 17:14:05 +0300")
>>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:
[...]
EZ> Please show the patch, it is hard to decide without a good idea
EZ> what is about to change.
Oops, sorry. Here it is (the change just wraps the bulk of a function
with (with-temp-buffer ...))
@@ -118,17 +118,18 @@ nnagent-request-post
(gnus-request-accept-article "nndraft:queue" nil t t))
(deffoo nnagent-request-set-mark (group action server)
- (insert "(gnus-agent-synchronize-group-flags \""
- group
- "\" '")
- (gnus-pp action)
- (insert " \""
- (gnus-method-to-server gnus-command-method)
- "\"")
- (insert ")\n")
- (let ((coding-system-for-write nnheader-file-coding-system))
- (write-region (point-min) (point-max) (gnus-agent-lib-file "flags")
- t 'silent))
+ (with-temp-buffer
+ (insert "(gnus-agent-synchronize-group-flags \""
+ group
+ "\" '")
+ (gnus-pp action)
+ (insert " \""
+ (gnus-method-to-server gnus-command-method)
+ "\"")
+ (insert ")\n")
+ (let ((coding-system-for-write nnheader-file-coding-system))
+ (write-region (point-min) (point-max) (gnus-agent-lib-file "flags")
+ t 'silent)))
;; Also set the marks for the original back end that keeps marks in
;; the local system.
(let ((gnus-agent nil))
--
Andrew Cohen
next prev parent reply other threads:[~2023-06-21 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 18:58 bug#64117: 28.2; "gnus-request-set-mark: Buffer is read-only" when exiting agentized, unplugged summary buffer Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-21 13:13 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-21 13:52 ` Andrew Cohen
2023-06-21 14:14 ` Eli Zaretskii
2023-06-21 14:22 ` Andrew Cohen [this message]
2023-06-21 14:34 ` Eli Zaretskii
2023-07-01 21:05 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-01 22:52 ` Andrew Cohen
2023-07-01 23:54 ` Eric Abrahamsen
2023-07-02 7:14 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rccao9e.fsf@ust.hk \
--to=cohen@bu.edu \
--cc=64117@debbugs.gnu.org \
--cc=cohen@andy.bu.edu \
--cc=eliz@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).