From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Fri, 21 Jul 2023 16:15:41 +0000 Message-ID: <878rb944wi.fsf@localhost> References: <87o7k6pmk3.fsf@localhost> <834jly351p.fsf@gnu.org> <87lefapkdx.fsf@localhost> <831qh230h5.fsf@gnu.org> <87wmyu8mi0.fsf@localhost> <83wmyu1l1k.fsf@gnu.org> <87fs5hemi1.fsf@gmx.de> <83edl11qzn.fsf@gnu.org> <874jlxebz5.fsf@gmx.de> <87lef9mqio.fsf@localhost> <87edl1scbw.fsf@gmx.de> <87fs5hmp6i.fsf@localhost> <87cz0lmoxy.fsf@localhost> <83v8edzb31.fsf@gnu.org> <87r0p1cta3.fsf@gmx.de> <87pm4ll7ox.fsf@localhost> <87a5vpcmc7.fsf@gmx.de> <878rb9l1f5.fsf@localhost> <87zg3pb6yt.fsf@gmx.de> <83zg3p9s39.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22246"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, Michael Albinus , 64735@debbugs.gnu.org, sbaugh@janestreet.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 18:16:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMsnj-0005WW-Rc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 18:16:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMsnc-0007Zz-5n; Fri, 21 Jul 2023 12:16:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMsnW-0007XF-D8 for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 12:16:07 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMsnS-0000tS-Je for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 12:16:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMsnS-0006XI-Fb for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 12:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.168995614225082 (code B ref 64735); Fri, 21 Jul 2023 16:16:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 21 Jul 2023 16:15:42 +0000 Original-Received: from localhost ([127.0.0.1]:34682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMsn7-0006WU-Vj for submit@debbugs.gnu.org; Fri, 21 Jul 2023 12:15:42 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:43329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMsn5-0006WG-4K for 64735@debbugs.gnu.org; Fri, 21 Jul 2023 12:15:41 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 634B5240101 for <64735@debbugs.gnu.org>; Fri, 21 Jul 2023 18:15:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689956133; bh=RN4+cEWqYGuroyNt2YKaOielEQOFdXNB3WmdrAO3nrU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=qvrCFkCp1z8/wldLRLrTjfiZQzjay/H1jGL1fuJ3tmWqpkM4vxUS9iYjakTnnikL1 na++iKE6r6AePtT5NolYs3UDN6QD+If1xojw+HHx3Bsz0XZNzjgC8vLPv7sxmN2JCO bX/P90XBCJ1xzfO+YGBcw0qzGBO5aIJBh03M4VfElTKfUmPFLLmeJqp8k25WT+IPP+ tmY6YuY0CNsPRk9R/rovasmeBGDU5ID7A9OFz9E+gzO3b9BApTq401/4DI59gjE/9X i5siw5gx+oZfmdELA8wdQ7MoRGIy7VMUZezWnXTD2RhgGp3CSjeHz3S1dbZRtFMpFo GjLE4A9MdFEAA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R6vmN1mdCz9rxY; Fri, 21 Jul 2023 18:15:32 +0200 (CEST) In-Reply-To: <83zg3p9s39.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265740 Archived-At: Eli Zaretskii writes: >> > (length (directory-files-recursively "~/Git" "")) >> > ;; => 113628 >> > (benchmark-run-compiled 1 (directory-files-recursively "~/Git" "")) >> > ;; => (1.597328425 1 0.47237324699997885) >> > (benchmark-run-compiled 1 (let (file-name-handler-alist) (directory-files-recursively "~/Git" ""))) >> > ;; => (1.0012111910000001 1 0.4860752540000135) > ... > The figures provided in this thread indicate speedups that are modest > at best, so I'm not sure they justify measures which could cause > problems (if that indeed could happen). Not that modest. Basically, it all depends on how frequently Emacs file API is being used. If we take `find-lisp-find-files', which triggers more file handler lookup, the difference becomes more significant: (benchmark-run-compiled 1 (find-lisp-find-files "/home/yantar92/.data" "")) ;; (3.853305824 4 0.9142656910000007) (let (file-name-handler-alist) (benchmark-run-compiled 1 (find-lisp-find-files "/home/yantar92/.data" ""))) ;; (1.545292093 4 0.9098995830000014) In particular, `expand-file-name' is commonly used in the wild to ensure that a given path is full. For a single file, it may not add much overheads, but it is so common that I believe that it would be worth it to make even relatively small improvements in performance. I am pretty sure that file name handlers are checked behind the scenes by many other common operations. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at