From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 65481-done@debbugs.gnu.org
Subject: bug#65481: Replace defadvice with advice-add in Tramp manual
Date: Thu, 07 Sep 2023 15:07:02 +0200 [thread overview]
Message-ID: <878r9iyvwp.fsf@gmx.de> (raw)
In-Reply-To: <87zg1zmfvc.fsf@gmx.de> (Michael Albinus's message of "Wed, 06 Sep 2023 18:21:59 +0200")
Version: 29.2
Hi Stefan,
>>>> The Tramp manual recommends `defadvice', but it is now obsolete
>>>> (commit 27ed565ec6). How about changing the below examples to use
>>>> `advice-add' instead?
>>>>
>>>> ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region
>>>> ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file
>>>> ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents
>>>> ./misc/tramp.texi:5531:(defadvice minibuffer-complete
>>>
>>> Yes, pls do.
>>
>> I was hoping someone more familiar with Tramp could do it, wink wink.
>
> I'm short in time last week and this one. Will do when time permits,
> likely over the weekend.
Surprisingly, it's a calm day. So I've adapted the Tramp manual, pushed
to the emacs-29 branch. Closing the bug.
Best regards, Michael.
next prev parent reply other threads:[~2023-09-07 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 23:09 bug#65481: Replace defadvice with advice-add in Tramp manual Stefan Kangas
2023-08-24 7:46 ` Michael Albinus
2023-09-06 9:39 ` Stefan Kangas
2023-09-06 16:21 ` Michael Albinus
2023-09-06 18:34 ` Stefan Kangas
2023-09-07 13:07 ` Michael Albinus [this message]
2023-09-07 14:03 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r9iyvwp.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=65481-done@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).