From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#66948: [PATCH] Add Completion Preview mode Date: Mon, 06 Nov 2023 07:36:08 +0000 Message-ID: <878r7b72qf.fsf@posteo.net> References: <87lebcqcof.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39227"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 66948@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 06 08:36:43 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzuA4-0009uU-Sk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Nov 2023 08:36:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzu9s-0004RY-4e; Mon, 06 Nov 2023 02:36:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzu9p-0004Qu-DJ for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 02:36:25 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzu9o-0000W3-UZ for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 02:36:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzuAQ-0007GZ-4H for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 02:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Nov 2023 07:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66948-submit@debbugs.gnu.org id=B66948.169925621727921 (code B ref 66948); Mon, 06 Nov 2023 07:37:02 +0000 Original-Received: (at 66948) by debbugs.gnu.org; 6 Nov 2023 07:36:57 +0000 Original-Received: from localhost ([127.0.0.1]:38610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzuAK-0007GH-Lo for submit@debbugs.gnu.org; Mon, 06 Nov 2023 02:36:56 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:34053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzuAH-0007G2-Tm for 66948@debbugs.gnu.org; Mon, 06 Nov 2023 02:36:54 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3E3C0240028 for <66948@debbugs.gnu.org>; Mon, 6 Nov 2023 08:36:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1699256170; bh=6VD7ltBaRLhSZOf/193T/XiZe9K2r9+YByLbYT9xNHo=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=lnDU9VRTxzlfeUabdt0vPIhyHRNBjIP6aBKr0OuD0nHGl3zEavOQoTVOB8nheb5sw cFex6XgUPp9A2bM8v5hPauUILUwcLpXYdtLXsjZopi/kn+K8hrDOKVK3T2OdFqjaDc TeZ4Kt13YnHK/HUb6qnerqkRJeGgbuMdIMlvlbkDGd8dUflSGjWDGNyhAtPK7CWY1j kImoff28A4JN6n882o5ooyNTH+oseSzcoFb7hktEBcZlDxUXDG5vI1HajpxfnXR3pR 258QFH9/EVLsZaZDZqpzQ2/PHe64BebPORH9bHcuFNknInL5XkNxYTwQzoBwC7v9/I FFcfq/Dfg8oRQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SP37F15y7z6txW; Mon, 6 Nov 2023 08:36:08 +0100 (CET) In-Reply-To: (Eshel Yaron's message of "Sun, 05 Nov 2023 20:42:44 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273862 Archived-At: Eshel Yaron writes: > Philip Kaludercic writes: > >> Eshel Yaron writes: >> >>> Tags: patch >>> >>> Following the recent discussion on emacs-devel[0], I'm attaching a patch >>> that adds a new Completion Preview minor mode. >> >> I didn't follow the discussion in detail, but is this related to the >> capf-autosuggest package? > > `capf-autosuggest` didn't really come up so far. It is related to > Completion Preview, but `capf-autosuggest` only deals with `comint`-like > buffers, while Completion Preview works in all buffers. I don't know if > and how `capf-autosuggest` could be extended to work in arbitrary buffers. It should be possible, but from what I see the capf-autosuggest code has a lot of additional integration into comint, that could probably be separated, or perhaps even build on your completion-preview-mode. >> FWIW From a brief test, my main annoyances have been that DEL drops any >> completion > > Thanks for testing. To have DEL not dismiss the completion preview, add > `delete-backward-char` to `completion-preview-commands`. Actually, > would it make sense to have that behavior by default? I think it would. >> and that there is no option to cycle between inexact completions. > > That's interesting, can you elaborate about the use case that you have > in mind? I thought about adding a command to do that, but I wasn't sure > there'd be a good use case for it since you can always dismiss the > preview (e.g. with `C-g`) and say `C-M-i` to pick another candidate. Just to use M-n/M-p to cycle through what the different completion options are, without having to request a window that might mess up my frame layout. >>> [0] https://lists.gnu.org/archive/html/emacs-devel/2023-10/msg00693.html >>> >>> + (pcase (bounds-of-thing-at-point 'symbol) >> >> [...] >> >> You can use `pcase-let' here. >> > > Good idea, I'll try it out. > > > Best, > > Eshel