From: Philip Kaludercic <philipk@posteo.net>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: Eli Zaretskii <eliz@gnu.org>, 68317-done@debbugs.gnu.org
Subject: bug#68317: Can't sort *Packages* buffer by version after installing with package-vc
Date: Wed, 10 Jan 2024 08:28:03 +0000 [thread overview]
Message-ID: <878r4xwq24.fsf@posteo.net> (raw)
In-Reply-To: <87edephi67.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Tue, 09 Jan 2024 21:16:06 -0800")
Joseph Turner <joseph@breatheoutbreathe.in> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Philip Kaludercic <philipk@posteo.net>
>>> Cc: joseph@breatheoutbreathe.in, 68317@debbugs.gnu.org
>>> Date: Tue, 09 Jan 2024 20:19:15 +0000
>>>
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>
>>> >> From: Philip Kaludercic <philipk@posteo.net>
>>> >> Cc: Joseph Turner <joseph@breatheoutbreathe.in>, 68317@debbugs.gnu.org
>>> >> Date: Tue, 09 Jan 2024 19:25:44 +0000
>>> >>
>>> >> Eli Zaretskii <eliz@gnu.org> writes:
>>> >>
>>> >> >> version-to-list: Invalid version syntax: ‘c99367ebc2f0afe0baaf2f5e5ca1ad9d62ba6e21’ (must start with a number)
>>> >> >
>>> >> > Sounds like package-vc-commit should be modified to produce a valid
>>> >> > version string (which SHA1 is not)? Philip?
>>> >>
>>> >> We can also adjust `package-menu--version-predicate' to handle
>>> >> non-version numbers, which I think would be more robust.
>>> >
>>> > Fine by me, but can this be done safely enough for emacs-29?
>>>
>>> This would be a simple implementation, I don't know if it is safe enough
>>> for you:
>>
>> Looks safe enough, thanks.
>
> With this solution, when sorting by version, packages at version 0.0.0
> are interleaved with packages whose version string is a hash, such as:
>
> breadcrumb c99367ebc2f0afe0baaf2f5e5ca1ad9d62ba6e21 source No description available.
> chordpro-mode a63fc0b7181299befc4496cba04e0f84d5953000 source No description available.
> consult-emms 407edec0f2a997e32cb1bbeff811f73b6fac42ac source No description available.
> denote 5e9b6b3bf0a81e00b0db0071f0c06a889f7e4a71 source No description available.
> disable-mouse 0.0.0 external Disable mouse commands globally
> emacsql 0.0.0 external High-level SQL database front-end
> hl-todo 0.0.0 external Highlight TODO and similar keywords
> hyperdrive 2930992446f508a7716b1e52a6aaf824d3f152d9 source No description available.
> jabber 6900d9e085bbb2ef35b731c661fe54fa88422d6a source No description available.
> ledger-mode 0.0.0 external Helper code for use with the "ledger" command-line tool
> lisp unknown source No description available.
> macrostep 0.0.0 external Interactive macro expander
>
> While this is a little bit awkward, it's certainly better than an error.
>
> Thank you for the quick fix!
I agree it is not ideal, I can take a look at it again after emacs-29 is
cut. But for now I'll mark the bug report as resolved.
> Joseph
next prev parent reply other threads:[~2024-01-10 8:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 8:59 bug#68317: Can't sort *Packages* buffer by version after installing with package-vc Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 13:03 ` Eli Zaretskii
2024-01-09 19:25 ` Philip Kaludercic
2024-01-09 19:53 ` Eli Zaretskii
2024-01-09 20:19 ` Philip Kaludercic
2024-01-10 3:27 ` Eli Zaretskii
2024-01-10 5:16 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 8:28 ` Philip Kaludercic [this message]
2024-01-10 9:06 ` Stefan Kangas
2024-01-10 19:10 ` Philip Kaludercic
2024-01-10 13:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r4xwq24.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=68317-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joseph@breatheoutbreathe.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).