unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: torsten.hilbrich@gmx.net, 68684@debbugs.gnu.org,
	iarchivedmywholelife@gmail.com
Subject: bug#68684: [PATCH] dictonary.el documentation
Date: Wed, 24 Jan 2024 20:04:58 +0800	[thread overview]
Message-ID: <878r4frl79.fsf@yahoo.com> (raw)
In-Reply-To: <CADwFkmk+D+KqhpErcF9BHxeeKf4=_QH6SWxHbM-UrX+_-EOfKQ@mail.gmail.com> (Stefan Kangas's message of "Wed, 24 Jan 2024 02:15:12 -0800")

Stefan Kangas <stefankangas@gmail.com> writes:

> Subject: [PATCH] * lisp/net/dictionary.el: satisfy checkdoc
>
> (dictionary-tool-bar-map): add missing period
> (dictionary-process-popup-replies),
> (dictionary-read-definition),
> (dictionary-display-tooltip): rename ignored parameters
> (dictionary-tooltip-track-mouse): describe what function does, not just when
> (dictionary-switch-tooltip-mode): reword docstring in terms of ON parameter

Thanks.  Nowayman, we cannot install this as-is, since the formatting of
the commit message does not meet our standards.  Please capitalize the
first character in each sentence, punctuate sentences with periods
followed by two spaces, and either omit commas after the identifiers in
entries sharing a description or move such identifiers into a single
line and pair of parentheses, provided that such line totals fewer than
64 columns.

I find that a surprising number of individuals cannot produce correctly
formatted entries on the first attempt.  Is the layout of our
documentation part of the problem?  We should consider why the 124-odd
lines' worth of advice in CONTRIBUTE are being overlooked by most new
hands whose patches turn up in this list, and even some old ones,
because correcting improperly formatted patches individually gets old
fast.





  reply	other threads:[~2024-01-24 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8734uof4m4.fsf@gmail.com>
2024-01-24 10:15 ` bug#68684: [PATCH] dictonary.el documentation Stefan Kangas
2024-01-24 12:04   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-01-24 12:20     ` Emanuel Berg
2024-01-24 17:07     ` No Wayman
2024-01-25 23:29     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r4frl79.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=68684@debbugs.gnu.org \
    --cc=iarchivedmywholelife@gmail.com \
    --cc=luangruo@yahoo.com \
    --cc=stefankangas@gmail.com \
    --cc=torsten.hilbrich@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).