From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Date: Mon, 19 Feb 2024 19:02:47 +0000 Message-ID: <878r3g9t0o.fsf@posteo.net> References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> <87edd8mnlq.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36127"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69141-done@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 19 20:03:52 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rc8vf-0009BD-LB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Feb 2024 20:03:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc8vW-0002Ku-4W; Mon, 19 Feb 2024 14:03:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc8vV-0002KT-5N for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2024 14:03:41 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rc8vU-00061p-TW for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2024 14:03:40 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rc8vq-00072y-37 for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2024 14:04:02 -0500 Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2024 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 69141@debbugs.gnu.org, philipk@posteo.net, philipk@posteo.net Original-Received: via spool by 69141-done@debbugs.gnu.org id=D69141.170836940127030 (code D ref 69141); Mon, 19 Feb 2024 19:04:01 +0000 Original-Received: (at 69141-done) by debbugs.gnu.org; 19 Feb 2024 19:03:21 +0000 Original-Received: from localhost ([127.0.0.1]:43419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8vA-00071t-Ba for submit@debbugs.gnu.org; Mon, 19 Feb 2024 14:03:20 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:55265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8v4-00071c-UQ for 69141-done@debbugs.gnu.org; Mon, 19 Feb 2024 14:03:18 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 12D17240104 for <69141-done@debbugs.gnu.org>; Mon, 19 Feb 2024 20:02:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708369368; bh=GcvyXDzzGyBMadjFv9OHbFGQtQ0IAEchUpJWfWiWNFA=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=pQ+O4KSd5E+5EiVOLwMkpx8nEJj2D6fYCjlK3/cDqUJ0cjp6b8dvJBIcAUYVuW3cL z3C2bmh6wMSVw6hg7co+2sVmnHYALDKWWwLdVu2FB1Cbu25e1C7cZZJPB+UHKqXEjy VK7FpUIvNKNi+5nUQBwpCQekDhzH9P9rzO3tUM5dghI/Okw7oTNLkH7sbIjQAytcD3 ygLJfZqMY2nfpKihCQ0aXhP7gXstocwv4JIKYdNjT13r+4x9rWtgji6mELneEoONZJ sMG4fLG1i/uV5foIJ6LGIu4O06D/os2cSkAB31648u8lQWI0JmbndFaB94kl3l1QR1 7SJtlFjIJKdOg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TdsP34yjSz6ty0; Mon, 19 Feb 2024 20:02:47 +0100 (CET) In-Reply-To: <87edd8mnlq.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 19 Feb 2024 08:21:21 -0800") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280291 Archived-At: Eric Abrahamsen writes: > On 02/19/24 15:54 PM, Philip Kaludercic wrote: >> Eric Abrahamsen writes: >> >>> Philip Kaludercic writes: >>> >>>> I use this command frequently, and am just as frequently mildly annoyed >>>> that attachments are always added at the bottom of the message buffer, >>>> instead of at point as is the case with 'mml-attach-file' (usually this >>>> is mild enough that I'd immediately forget about it). This patch allows >>>> disabling the behaviour: >>> >>> This looks fine to me, thank you. Would you add a :version to the >>> defcustom, and also a mention (with index entry) in the Gnus manual, >>> "Interaction with other modes -> Dired"? >>> >>> I guess 'mail is a fine group for the defcustom, kind of hard to say. >> >> How does this look like: > > Looks good! Thanks. Pushed, thank you for your comments.