From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Date: Fri, 01 Mar 2024 05:00:34 +0530 Message-ID: <878r32u9ut.fsf@gmx.net> References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 69232@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 01 00:32:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfpsl-0006HM-7I for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Mar 2024 00:32:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfpsI-00088i-9G; Thu, 29 Feb 2024 18:31:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfpsF-00088Y-9c for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 18:31:35 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rfpsF-0003s5-1U for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 18:31:35 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rfpsg-00010m-7h for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 18:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Feb 2024 23:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69232-submit@debbugs.gnu.org id=B69232.17092494813836 (code B ref 69232); Thu, 29 Feb 2024 23:32:02 +0000 Original-Received: (at 69232) by debbugs.gnu.org; 29 Feb 2024 23:31:21 +0000 Original-Received: from localhost ([127.0.0.1]:35650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfps1-0000zo-A9 for submit@debbugs.gnu.org; Thu, 29 Feb 2024 18:31:21 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:50339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfpru-0000zV-AT for 69232@debbugs.gnu.org; Thu, 29 Feb 2024 18:31:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1709249440; x=1709854240; i=jimjoe@gmx.net; bh=lNY9EV7DlrQFZWpvzEtF5JAugz618rRNHieUerHBJ+s=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=sWXndZhD9+19Km8AJrb8ft6ogpcbBJuroFRb/zap+FzG6ZVe4qWWl8mC3HC2CLu8 yp+TghuSYEm4K/WyriGE0PpH2d89c2yngMDe2ZcQud1dxA/dV329nRlQtdIV4pCAL s6CzpjQOnSf/hc+5EcrvjlUrKt+qO6QNwWDnYiDHX/sw2ttOzLEDvS3dJIcuKmGfV M2QQHgml3cZbLf2P4LGwgBgXV1EL8XFNAx7+YUR3oxJBlDFLNEUnlglpiYIjMCdIa qFqx8EIYpAoE00ZUDqR0mKhCNLDuwhvpdDngkQU+44Y6H7Z/lX0XKnR/LorrM0wCq Mqq2LY7WzG63gzuVDw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-15-5518 ([117.216.1.160]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MbzuH-1rAMK01m3T-00dUT7; Fri, 01 Mar 2024 00:30:40 +0100 In-Reply-To: <77426857-4d81-29da-9b1a-70931393215e@gmail.com> (Jim Porter's message of "Thu, 29 Feb 2024 09:32:09 -0800") X-Provags-ID: V03:K1:kFBboma4B3iAHDQRAULfjyJ82kh1QOM3c5Fcq2ExG+AvS326JqG Tf984p0A1zfuJUY14N00wEkygsbAFmYUoY3iStkjgcertIeOGLJbqFSdknN6HoaOO3zrEPQ GH/4pZb2OmA3yu3f6FVFAlBGqnZZMHRAj/GYFsIwOCOBQrgsvkLC9LL/eOBwsnMY+74pzEV 4dW77gdP01GPgdn7Zw+Sw== UI-OutboundReport: notjunk:1;M01:P0:wcPMDfT5h0w=;mMTVOcwLvgwpjk1o+Aopl7JRTpq pWO6rT+yOhRokoCRsDRo6JdgfWrwZYili2JQU//+ZgNmnwZMRfVQPx0HQgFCphe3fQUNchFQ+ M8ZNEMtSRTSUUZz6FobgdDB39p6b6hnYOT9xZhDzIub72BROs0Jg9RPlV3dybOZ6h/oiekVFq 58sB2xzu0ICyddqQ8HtrpQDl48pd5RXgeWO2J+MbcxqGzXc3JDdXweoOLhGT3Ft2tN5i9r5aF eE90qipwQgdpM83U8nDvd6VT3/yynyem/GSdXgDaTU4jyxTTHAIDGbozaUw0Yg8+U2SS7wiTN zcPIHmlJnkCE0xcjBJIfKLD9i2ZFQfslaBke5fx3W9/dHbAjXDBWjQHhKmVNLNluDfS84wgse IActCb6Au5slksjWhwDzpfru+PEE5Fwar2kjJ2hiTWcHOwMyH3KwL3rjfMEqm+gRQDfhfku9D VddyaL81056Jufu6w5OCuZ9F8cmExFpQzBCQ/pxGq5DB/PxKoQUBtklg/2V5Yvw3nduX/OgJF CIg3FC4IMXjP7NfD+tR3pBHEiw//b44DCgit9MgYUUOMT7XQ2JBGaSrwJexLGiGLetGg3MRWN HwuNBpSAKJj3Orya4dkMXhcem1wdnbK1p3bp96OWIznGd2d0RUAyRlU6dSk9j8sPRpYmQLZv+ v2AtoZpetb3g1N/o96Tvq+EjjcvpBkOIAheADvCYe6cW7v8QQZD6JDzRavrD7iMq6uLcPeWvJ hhvXO/KXE5Md3ZC0hSuKLVhPv8Ot8qrDeqEAIbpVmASbUDlcEhXCrfqek2YAa9p9NAfAEgIU X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280824 Archived-At: Jim Porter wrote: > On 2/28/2024 11:03 PM, Eli Zaretskii wrote: >> Thanks, but I thought we were talking about some user option, since at >> least some people said they don't like what other browsers do? > > I'll wait to see if James has anything to say about this patch, but my > understanding was that his problem was that the first version of my > patch *didn't* work like other browsers, and he wanted something > closer to that. The current patch is much better for me personally: 'l' and 'r' now do what they're supposed to do. But my ideal (short of any advanced 'tree' mechanism), as I originally stated, would've been to _insert_ (rather than _replace_) the new history at the position in the current history where it's created (but I see that there's no SOP for that in (info "(elisp) Minibuffer History"), and that there could be performance implications). > I don't mind adding an option though, once we have an idea of what > options we'd want to support. One simple way might be to add some > option like 'eww-history-replacement-function' (name suggestions > welcome), which runs any time the user is at a historical page and > navigates to a new one. This would default to the hypothetical > function 'eww-history-delete-future' and do what my latest patch does. > Then users can write their own functions to modify the behavior. Why not simply make 'eww-save-history' customizable? > It would also be nice to have an option like the Emacs 29 behavior, > but with the bug in my original report still fixed. I'm not sure > exactly the best implementation for this yet though... TBH I don't think anyone would have been (ab)using it effectively because each 'l' or 'r' made things more complicated; but the advantage that *all* of history was available with 'H'. (I'm using this patch and will let you know if I see anything amiss) Regards, James