From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) Date: Fri, 05 Apr 2024 15:53:04 +0200 Message-ID: <878r1rgblr.fsf@betli.tmit.bme.hu> References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4020"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: Alan Donovan , 70193@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 05 15:54:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsk1P-0000u1-51 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Apr 2024 15:54:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsk10-0002ET-Tu; Fri, 05 Apr 2024 09:53:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsk0z-0002EI-3d for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 09:53:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsk0y-0003Dz-QP for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 09:53:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsk14-0006gS-5Z for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 09:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2024 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70193 X-GNU-PR-Package: emacs Original-Received: via spool by 70193-submit@debbugs.gnu.org id=B70193.171232520325504 (code B ref 70193); Fri, 05 Apr 2024 13:54:02 +0000 Original-Received: (at 70193) by debbugs.gnu.org; 5 Apr 2024 13:53:23 +0000 Original-Received: from localhost ([127.0.0.1]:35463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsk0R-0006dI-86 for submit@debbugs.gnu.org; Fri, 05 Apr 2024 09:53:23 -0400 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:59603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsk0M-0006cO-E8 for 70193@debbugs.gnu.org; Fri, 05 Apr 2024 09:53:21 -0400 Original-Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a51a8749478so63036266b.2 for <70193@debbugs.gnu.org>; Fri, 05 Apr 2024 06:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712325186; x=1712929986; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=mDvfQL6lFYB0AzpIWp5/tZORcvG6gQMJruNhod03r8Q=; b=dMYRH3fAqm5dQ9d1CgGUIqlyrX7RvEMEisO9Yuu9n2KFkNHNvvIOvLkBShNWObGJGN dFn1MEzx2dIl4WQDHNoTyXxUlZ0A/d+VwwPEt0TvszwOnfNkg1S54W/12bmatG0IdRHy 4BztQhrkotbbNWNMWPSZ8NFUcl86QHgcHoz81VfWf65CpwpkRsjLR3445cFjDNHO6Z+P xjmqjhWfsyI9YHTIIhfbrfvT8Uy3TBUZYzUbHWJxiaeyvm8jeMYqbZuWRSF/+doF06nK HVtegb+zCoXH75oaBufkApJK1BH2wYFV72mzo7frcr55MbAvdxaW3KBvLaHvaj4Dl61G td/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712325186; x=1712929986; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mDvfQL6lFYB0AzpIWp5/tZORcvG6gQMJruNhod03r8Q=; b=IqRPtVmfomeMImuKRqz5RfUDkdOJB16tuf7pCCX/5pPI+7ITqTlcvN1RMTAlzhwtVT R7lUATr3xmlNgcxFYCTrQAIpoRJPv+Er1iCzFWtTmYfU6Qx4fEqu/EfGTl8M9ig9inBB esB+m9YZ/4809HnCIekB6RsvXJiInwRhpWnQwImbRp8KWNGasbEOLxzr6VMSMtc8b+Oi Z/Btzjs2F3mwW7r3D/S4QDhsf54m9kWW7oC1tabWQ5dyabn4aBcsFNjeO4wYmlNKxixV b6urtWMCiwxzM9mnIKuLa30sUfRC6DviKV+/juP93AURoF6am2a3vp8xcozS4I1HhNr2 uPWA== X-Forwarded-Encrypted: i=1; AJvYcCUIBSpGRUaOPIf5V4YRg2IS3+tzjCkbBn+sdDWAQkSBPw2wdeh97ihrFCXpiIxAxFeOih6QDyXiWTgQAZoDrCuXj11uy2M= X-Gm-Message-State: AOJu0YzQeeVXb5+t61rcnos+vWilAv5CYjpufhM7YhXQle2wc+nSxTAA N2kTlNZKFLoiOR0jUqWXnJMms+x1LZEQtl3jUFGwPH0BslK9Hv8Hx4FS4+O5 X-Google-Smtp-Source: AGHT+IFWfoINBNTIcARLBBWyqABnIGyjKyOAl9fg6rBAtcP2gkOzpNm/b1xl1ch+1hcO+rZH/ZpBXw== X-Received: by 2002:a17:906:f90a:b0:a4e:14e5:5737 with SMTP id lc10-20020a170906f90a00b00a4e14e55737mr1283299ejb.45.1712325185819; Fri, 05 Apr 2024 06:53:05 -0700 (PDT) Original-Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id s11-20020a170906c30b00b00a4e222225ebsm872684ejz.15.2024.04.05.06.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 06:53:05 -0700 (PDT) In-Reply-To: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> (martin rudalics via's message of "Fri, 5 Apr 2024 11:07:58 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEU2EgDVmFNHKAa4dz4q AwCDUSH2zWrE61tmAAACeklEQVQ4jU2UwY7jIAyGEZN5ABSFc9Ytcx6K6DmqmHsD8tyZKrz/I+xv yI6WKlHlj982tomiVckiWrUrgRU5jlqMpJKCkch5W419DQAiQGHDxdrWmm0/2kXCApiUmrZLq20s cjexq3VL25QuxjY7wOcJVEpb+jLeGLAK+OMyaa1hx9rFbkwHFWBVA2y8w1wHaLE7GuDdw5cEuOM5 SLIdrpwBkN0ezwI7nYoiilqthbcYc89KgC5+NnaOHGbZz0T6BCEgOLJ0vmYXuNdPAIXgDZJhF2Yu fjnPNwAsoUTUN/P8q3AAyz4zB/xmifEfiIbvS4jh7b7QqZiSm4MJC5kXNpCRaOsoyQXAMN2XCJfs j94NKfo7ACKUEgKE3y+Sg4jibUZ1A0jgYpxtvYMC3gHaHPq6x32ACeALIZoZxB+l9VrRNIA1ncRg wwC8pvQIvYO+a2yt3VXMVyli6L0VV6aOrJa4CpilVQA+eHt0xavk61akih5BUMay/0BAqu783C5h FifY/3QsAIoWYk6PgpwAzLI652+96e2IfN2cF+BD1uT23F21Ghh5OUl4RlO15oh5A2iv+Zk2wsjZ 2DtB5Sm3A4P0+kyb2vs4iEW7G9ohoN3Stl2kVat6MCkXldo6OKaE8P6GhmrKKxWZXQH1iklhhn+d iVeNf6mDdkV0ltFwApRbp+kXSGBFHGV2aPqnIIyQyzhD5n47khqKI08bIapcas4O+hPkct20NAEv ALRuZFUp3PrnQSAm+4lTdHCsYYZ/nGqQrM5z3NS3zefFxkfFPRFbsjpIfbTlvF3ibpVZQ9nzqv60 F/KXSRLJ1AGappJulZll70N/qz6EfwEOCdYOuTHAzAAAAABJRU5ErkJggg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282705 Archived-At: Hi Martin, > The attached 'window-recenter-region-start-position' should address > that. I am not aware of whether we have a function on master to get the > line height of a specific window as if a specific buffer were displayed > in it so I used 'frame-char-height' for the window in question. The > rest of the function is straightforward but there might be off-by-one > glitches. I have a not so recent build: Development version e4d1739a2917 on HEAD branch; build date 2024-03-16. But when I debug window-recenter-region-start-position, the height is set to 0. The patch below seems to fix the problem. Thanks, Felici=E1n --- /tmp/recenter-region.el~ 2024-04-05 15:35:24.043123595 +0200 +++ /tmp/recenter-region.el 2024-04-05 15:47:55.430121441 +0200 @@ -19,8 +19,9 @@ (region-end)) (with-current-buffer buffer (point-max)))) - (body-width (window-body-width window)) (body-height (window-body-height window)) + (body-pixel-width (window-body-width window t)) + (body-pixel-height (window-body-height window t)) old-buffer old-start old-point height start) (unless (eq (window-buffer window) buffer) (setq old-buffer (window-buffer window)) @@ -29,7 +30,7 @@ (set-window-buffer window buffer)) (setq height (/ (cdr (window-text-pixel-size - window from to body-width body-height)) + window from to body-pixel-width body-pixel-height)) (frame-char-height (window-frame window)))) (save-excursion (goto-char from)