From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70524: [PATCH] Fix `map-elt` with `setf` for subplaces Date: Fri, 26 Apr 2024 14:19:34 +0200 Message-ID: <878r10xqnd.fsf@web.de> References: <87a5lji9bg.fsf@web.de> <9a68b4fc-55ee-41fc-aa2c-c69e9498aff0@protonmail.com> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15026"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , 70524@debbugs.gnu.org To: okamsn@protonmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 26 14:20:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0KYk-0003dx-52 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Apr 2024 14:20:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0KYO-0008QJ-Ub; Fri, 26 Apr 2024 08:19:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0KYN-0008Pj-FB for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 08:19:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0KYM-0003Ji-Lc for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 08:19:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0KYe-000673-Fq for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 08:20:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2024 12:20:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70524-submit@debbugs.gnu.org id=B70524.171413397623178 (code B ref 70524); Fri, 26 Apr 2024 12:20:04 +0000 Original-Received: (at 70524) by debbugs.gnu.org; 26 Apr 2024 12:19:36 +0000 Original-Received: from localhost ([127.0.0.1]:34266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0KY9-00061K-Ru for submit@debbugs.gnu.org; Fri, 26 Apr 2024 08:19:35 -0400 Original-Received: from mout.web.de ([212.227.17.11]:34007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0KY5-0005z9-2g for 70524@debbugs.gnu.org; Fri, 26 Apr 2024 08:19:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1714133935; x=1714738735; i=michael_heerdegen@web.de; bh=+xsANSSc8vLAIB28eMxzvCRP9S9Qm+KjzEOnbAPfcso=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=oVUm2aa9DWb0cy6/C+Pu/ZhMLn1qwV2y9m9MAOUKG5UfzU9WCADCVHOCS0gzbVey VG+4iSD4WxtDI2BwcJNWvf68bVBYC/no+Iyxye3Vz5pc4CLsRidHWljwFOgqmHVWk jGjInrfGWf1/2ENob9CO3RLOhqJvDhdLQ+7c3JDyhOGwTpqqiKTiOm8INfZxI7pel px2jI+6HethYCd4q5rU6kjpEaVhmMLwN8UeZZIx2l0pqDVer3qUT0uxqwjrPQn+jR 02k5da1ePVpB5hWJajvGFr7lfOyxuh8aWqLjpkxa7oUCuqB0VI1bulmGDceVbyAPy nIqYfP635J/tWQ6CsQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.57.248.23]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MRk0W-1s6TLh2BUA-00Tm6c; Fri, 26 Apr 2024 14:18:55 +0200 In-Reply-To: <9a68b4fc-55ee-41fc-aa2c-c69e9498aff0@protonmail.com> (okamsn@protonmail.com's message of "Thu, 25 Apr 2024 01:59:36 +0000") X-Provags-ID: V03:K1:6CtdO+IujH10XJQmcBsFVFtH3/lb3Q8Cm+pCiS2snrHHdCCtzIY PJnH+KJwIOekrOnYFEUeMbUrL5QPNjF6HWakQ9a8+cZrqZhddzeTGogenhXnzzA8r7oA9Xv z1/04NAHq5aCxOwJ6Bqj92O0bdzpWEbrRbw2W152NnG9jhttvonJRdoJRkTG2wmMM5bvHCs EzsUUUoXXes/Th+MuJaDA== UI-OutboundReport: notjunk:1;M01:P0:1jsgRfWCfjw=;0Cvotpyo57BjsY1KdZ2Mz9Qbz8g UnXxf57Uhzyk91pxGQWlcY4uuOCE/0kAn+smVgK9D+tyKrmg8mkYQDv4keynU1IDUReDZZ+Xu Odb65z+35wFhmGz48Sq8cipjSCLwLECCk+IEAUG9GAzVBcYDcc/4jAjAjBKSYHwKaMTqGeZCl mG8dx2iykSrpHc1X2dkdEj8whDC6/WvR1s53HG6XPN2FaCTZXRrH5SZdP62dV1GI9om354Lpg +LCEkrZTWjoEiTY6SDcEYWY76zrr6lPRw7tDi5d+s1O7r6M80IMoG/7j2UV4YHGds85exd4H2 SnIS0zoPoltwhZUpmxccfEzHuR/r2rIGTvouJWCzTq+XR5ypFW6r884/4NYYU3XJjXf8iunyd C3aDb102PcrARz5S3j//JXkLfIScdSfeZsGdRKio9ktAL86wtzl3EoehjZsjeVv1bja2RZU1q viInZ+MBFhj4/D+HnUuAy2UMSmWxiNOspY4GC77IAbaJhsP8qcCFNjMBKPg06d/3pasXnJo7M JAlWJsNdS8FHe6NThUSi4NHrTCWxjBhABJ+2HehwwgypOhdEmLr63baG/ml7+gvjwuiSK/yhb q6JPysXsdOvsCrbT3YFrrd/L7Ei9APARjYTXg962a/DHa6oLh1Izfq0M1Q5EYuGLcPzryNunM JqZPnJDU2v7uV4RIr+b61fcm5sFfZH1/sZHkyUYDwsQH12JCmjEAEX197nLNUw2215pGAxsbT Xq7Acp7b2Z9ohGYzfhKPGM8S4YJBw6kUGbxR82K6hGrVzv//+jbrjXvxJMSOmQtzRIa4ndgc X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283986 Archived-At: okamsn@protonmail.com writes: > My purpose with this patch and for bug#68863 regarding `seq-subseq` > (which does not currently support `setf`, and I think should allow > subplaces like `substring` claims to) The `substring' gv-setter doesn't need a loop however, it creates a new string using `concat'. Your patch would probably "work" ok in this case, but I'm not convinced that this would be an improvement, still for the same reasons. > was for destructuring as `setf`-able places, like in cl-loop's `for > VAR in-ref LIST`. I have implemented that for my Emacs Lisp package > (https://github.com/okamsn/loopy), but not all of the `setf`-able > destructuring constructs support sub-places in the expected way, due > to how some of the GV expansions are defined. But if loopy would base on an inefficient implementations this would not be useful. Are there examples where your patch is really a clear improvement? Michael.