From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69605: [PATCH] Query Eglot version via package.el Date: Fri, 03 May 2024 18:13:56 +0000 Message-ID: <878r0q69wb.fsf@posteo.net> References: <87y1auo0nw.fsf@posteo.net> <87seyz73bs.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40929"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69605@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 03 20:15:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2xRC-000AOu-0W for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 May 2024 20:15:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2xQq-0000de-Vr; Fri, 03 May 2024 14:14:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2xQe-0000d6-7g for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 14:14:40 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2xQd-0000GO-VP for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 14:14:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2xR0-0005US-9f for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 14:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2024 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69605-submit@debbugs.gnu.org id=B69605.171476007521079 (code B ref 69605); Fri, 03 May 2024 18:15:02 +0000 Original-Received: (at 69605) by debbugs.gnu.org; 3 May 2024 18:14:35 +0000 Original-Received: from localhost ([127.0.0.1]:48041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2xQW-0005Tu-Ey for submit@debbugs.gnu.org; Fri, 03 May 2024 14:14:35 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:51727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2xQQ-0005Tm-RC for 69605@debbugs.gnu.org; Fri, 03 May 2024 14:14:31 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E13A8240101 for <69605@debbugs.gnu.org>; Fri, 3 May 2024 20:13:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714760037; bh=xyzTaxfjxld0oGAkSVlyTLf6/IQsCxHlJcK7+WFxULA=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=iH17bPObVyj+k/xbzXVh+KWcOijtEzwr22PnbdgCzqZv1yqPJlGVlrE/8k5gd80LC vHQAjecVWMmPaZPxaTnNsc6oMWMejEaBJRyq25Y1mLBv1ZmAYvEV7XeARtKa7imecu sPW1R2MFIxcYBk2kFSzlorMghC4Z5bqUxuYe+79sRioCPikjXFIr5S5XRprPSkcTO0 2PNMPDCScw5ELQJFx1KjYIeYUz+AW6WRHBCpviaPlpk46VgRh/Fm0/GcC2K8iaYN7l iRdrhVfJLKRcAeNaO8ciOdht3l/7iqmSfLE38H3Nsz3aPZKoWyUiyMGL0FEUG10dJ9 jNoOnCGRDGb7g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VWJpY2559z6tm8; Fri, 3 May 2024 20:13:57 +0200 (CEST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 3 May 2024 12:54:05 +0100") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284393 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic wrote: > >> Ping? >> > > Patch looks good to me, I'm generally in favour of things that replace > Eglot-rolled facilities with standard ones. > > But I haven't tested it. What will `package-get-version` say of a master > build of Emacs where lisp/progmodes/eglot.el has changes that haven't > been published to GNU Elpa yet? Does it even matter? It will just extract the value of the version header of the compiled file. > Anyway, I think the change is safe to install, just please make sure it > doesn't trip the GitHub CI (it shouldn't). The three tested versions on GitHub all appear to pass the test. I'll push the changes to emacs.git for now. > Jo=C3=A3o --=20 Philip Kaludercic on peregrine