From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thuna Newsgroups: gmane.emacs.bugs Subject: bug#72434: [PATCH] Print list-ending comma/backquote forms specially Date: Sat, 03 Aug 2024 03:44:30 +0200 Message-ID: <878qxemlc1.fsf@gmail.com> References: <87ikwimlxr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33732"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 72434@debbugs.gnu.org Cancel-Lock: sha1:doyHmRcCDs/iM8dWwIEDbq1tY3E= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 03 03:46:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sa3qU-0008gM-9k for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Aug 2024 03:46:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sa3q5-00086b-AA; Fri, 02 Aug 2024 21:45:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sa3q4-00086S-Av for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 21:45:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sa3q4-0004w2-1y for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 21:45:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Mime-Version:References:Date:From:To:In-Reply-To:Subject; bh=zYholFYLXzhXYgJB9BtNf3puotm5K4rZVBY8CrEaic8=; b=Qgzv1ydpyOle4SxWRNh//RN01/twGOEPTXu2iYgULFUNOXRHOpv0F26iJ4UnyVz1elwosnSPzoq8vE0YlkvtK3iyfP5F14VOlB0pIlu/N/l9Mr3XM66EVUI+YCs2ReQS+hd0s6iLO4omXBdJ+NpEBibj/dwu3fO3ZI3ScOJsVfp8Z460yjbIczQQdFP34szuSua4SgIyD/iPDUoU4neKY2Yau7CFEfv1Rw3MF9YHxACMLShiWDuxXUv1aul16gMX1i+w3gLWQIkX7Jne2oR3XkcEo5PtVGUXP0Cu3A6TPsqs0YogIaeqxQA0kjVYK17n9AEbSo5P5dDgseE+5XE0EA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sa3qM-0003XE-0o for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 21:46:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87ikwimlxr.fsf@gmail.com> Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Aug 2024 01:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172264950113476 (code B ref -1); Sat, 03 Aug 2024 01:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Aug 2024 01:45:01 +0000 Original-Received: from localhost ([127.0.0.1]:53909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sa3pN-0003V5-4H for submit@debbugs.gnu.org; Fri, 02 Aug 2024 21:45:01 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sa3pL-0003Ux-10 for submit@debbugs.gnu.org; Fri, 02 Aug 2024 21:44:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sa3p1-00082p-Ot for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 21:44:39 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sa3p0-0004fA-E6 for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 21:44:39 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sa3ox-0007KD-0B for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 03:44:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289657 Archived-At: > (This patch follows from 72334, but that patch is not necessary for this > one to work.) Actually, that is incorrect...-ish. The specific problem happens when you encounter a comma or comma-at while not inside a backquote. With 72334 this is not a problem, but without it you end up with the (unevaluated) form (foo bar . ,baz) printed as (foo bar . (\, baz)) which is obviously not ideal. It /should/ be possible to lightly change the patch to have it work, by checking `new_backquote_output' in case the car is a comma or a comma-at but honestly I would just rather 72334 be pushed instead.