From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Mon, 30 Sep 2024 17:38:39 +0800 Message-ID: <878qv9scps.fsf@melete.silentflame.com> References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> <87y13dfgzz.fsf@melete.silentflame.com> <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> <87h69ydnvd.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29124"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73387@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 30 11:39:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svCsn-0007Jp-Gt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Sep 2024 11:39:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svCsP-0002a0-Ll; Mon, 30 Sep 2024 05:39:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svCsN-0002QW-3B for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 05:39:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svCsM-00084H-Qi for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 05:39:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=S6LebCmS5xXr0mw8k3F/kVqrWJcS6zQXF9s7bWW5cPQ=; b=kOzPhDvL0nK4aktHbT0GeucWIC2//bK6BsNFXU+VwjI2cTtCdsXF2fn6IKq0FgDVCXpl6/pKe4EGC6t1StaFQ6y2TSlDSEKR5Deoq8jTBk1IElMMnNXOqCoXMPp+EtMMczcEjMNaBorNnCyLI7tgT18tenFwga68747u7aNnmfYkAYx1hc9n0Yfp/z1fWvmU/uF1BHgOjWQ9HZd4MSLd9ENHCGRI207ckHkoWeXEMFg8EIRymtmlhqONU7skupL9dz8/+MrqF/grRiEGIIHmMskk+Vu22Uo60LZF6754pAFsGvH+t1ufsRd70WcZu6fh6R+/5LMbVp7X3AJuhTyV4g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svCss-0000Js-Rw for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 05:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2024 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.17276891691069 (code B ref 73387); Mon, 30 Sep 2024 09:40:02 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 30 Sep 2024 09:39:29 +0000 Original-Received: from localhost ([127.0.0.1]:44738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svCsL-0000HA-0y for submit@debbugs.gnu.org; Mon, 30 Sep 2024 05:39:29 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:56976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svCsI-0000Gq-9W for 73387@debbugs.gnu.org; Mon, 30 Sep 2024 05:39:27 -0400 DKIM-Signature: a=rsa-sha256; b=ZxK7Gnj0REVONT5v5SO15Iwy8KT/Fm26nRgjWYEaNg13CXNQQBBVgrEHHZ/DaulykR2mwVqy0q1dgp2y9Yk39/+B8ao8wM6RKcDsOCW3ZPf2POKXTUTv9/ob4uca4+uPObmd6oBMY2XTjIPtyhCfmNI1YFYg1QVxUqmcuDVq22Gbe2lh9AXpXbNl+bYDYgF2lPfV6h3c0gngNFbX62gZL/0sv3ci7Zr98rd8sZU8BQ61AZ55jA/hjI08OvoydPHgxHuLRhJEo5oalxt40vK+vdl+FqT/JOyF0+lY0kcMcfhI5TUjGFVBJat024hPYxGv/iNnkhDmXFf8F+49Ag6KRw==; s=purelymail1; d=spwhitton.name; v=1; bh=SEfayYzNdujNLo7MhVoGDoIVllokd7TyEWPBAYua3MQ=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=WlaZD5LLoKDhvBC+EFLwVWuxr+1/IIEw/mJ3/3j7gEMZxLfk+IbkzIs3feFnbTlw6gSzesjyrxyYoV5+Eynom8cBkT8/KJ/gcJp80GUttNY2vGaY62tHQ9HrACpPruw1ZyNpARNsfY/2dAr6nH/QO/uAyhuOnHTJP14d0ylE5lW+G3xhpsuxU+4jOico5OaHDc1EWuuy/Eq8WTpD70T3STGuCODe0Z3EREfamCPpqEg1FBZjftK8JGU4daiLWQu6Um6P1bYf2Qr/BkGYl0Aqnw9mHnJfy5P82zvbf0ysTLUh67YNIO3yBTd9tsTpcDb5LMzC5ajOcV7wX/qI813QMw==; s=purelymail1; d=purelymail.com; v=1; bh=SEfayYzNdujNLo7MhVoGDoIVllokd7TyEWPBAYua3MQ=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73387@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 960300349; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 30 Sep 2024 09:38:43 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id AC8DF7E1ACF; Mon, 30 Sep 2024 10:38:39 +0100 (BST) In-Reply-To: (Dmitry Gutov's message of "Mon, 30 Sep 2024 03:27:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292700 Archived-At: Hello, On Mon 30 Sep 2024 at 03:27am +03, Dmitry Gutov wrote: > On 30/09/2024 02:46, Sean Whitton wrote: >> Hello, >> On Fri 27 Sep 2024 at 10:13pm +03, Dmitry Gutov wrote: >> >>>> What do you think about this: >>>> - add a command which does the kill-all-but-this-hunk (or hunks in >>>> region if mark active) thing -- it's generally useful. >>>> - make C-x v v on a narrowed buffer, by default, issue a message saying >>>> "Cannot commit patch when narrowed, consider " >>> >>> Or it would implement that previous alternative - using the modified buffer >>> string that's limited to the current narrowing. >>> >>> I'm somewhat concerned about supporting both approaches (how different are the >>> code paths going to be?), but if that's needed for usability, perhaps it's >>> okay. >> Hmm, I thought that we thought the modified buffer string approach was >> too messy. Would you mind outlining your proposal as a whole and how it >> differs from my most recent one? > > Actually, how about we start with your suggested steps, sans for the last one, > for now. Meaning, just aborting with a message when the buffer is narrowed, > without the user option. > > We would not be removing any existing functionality this way (this scenario > didn't work before, after all), and we could add it later. > > Would that work for your habits/scenarios? You mean, just adding the command which kills hunks? -- Sean Whitton