From: Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 75359@debbugs.gnu.org
Subject: bug#75359: [scratch/elisp-benchmarks] test dependencies
Date: Sat, 04 Jan 2025 16:37:26 +0000 [thread overview]
Message-ID: <878qrqfse2.fsf@protonmail.com> (raw)
There are dependencies between emacs-lisp-benchmarks tests, meaning we
can't always modify one test without affecting others. The ones I'm
aware of are:
- elb-bytecomp.el uses elb-smie.el as compilation input (in this
context, elb-smie.el is a "resource", not source code). If we
modify elb-smie.el, elb-bytecomp.el results will change and become
uncomparable.
- elb-scroll.el uses elb-smie.el as a prerequisite. If we modify
elb-smie.el, elb-scroll.el results will change and become
uncomparable. Furthermore, elb-scroll.el relies on elb-smie.el
being compiled in the appropriate fashion by some external
mechanism. (I think the best solution here is to merge elb-smie.el
and elb-scroll.el into a single file declaring several tests, using
the established ERT test framework)
- bubble.el and bubble-no-cons.el both "provide" the same feature.
I'm not sure whether this causes any acute problems, but it
demonstrates that the inconsistent use of (provide) in the
benchmarks is problematic. If we ever load tests using Frequire, we
will load the wrong files. If we don't, provide shouldn't be
necessary.
- xmenu.c is used as a resource; this is fine. But we must make sure
we never copy the "current" xmenu.c to the benchmarks directory
without clearly indicating that the benchmark results will become
uncomparable.
next reply other threads:[~2025-01-04 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 16:37 Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2025-01-06 9:53 ` bug#75359: [scratch/elisp-benchmarks] test dependencies Andrea Corallo
2025-01-06 14:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-06 14:47 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-06 14:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qrqfse2.fsf@protonmail.com \
--to=bug-gnu-emacs@gnu.org \
--cc=75359@debbugs.gnu.org \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).