From: Stephen Berman <stephen.berman@gmx.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 1488@emacsbugs.donarmstrong.com
Subject: bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer
Date: Fri, 05 Dec 2008 19:17:46 +0100 [thread overview]
Message-ID: <877i6etrjp.fsf@escher.local.home> (raw)
In-Reply-To: <493966D2.5050108@gmx.at> (martin rudalics's message of "Fri, 05 Dec 2008 18:37:22 +0100")
On Fri, 05 Dec 2008 18:37:22 +0100 martin rudalics <rudalics@gmx.at> wrote:
>> You're referring to the parenthetical note below my patch, right?
>
> Yes.
>
>> So I
>> tested my patched version of dired-pop-to-buffer after applying your
>> patch. The result is that dired-pop-to-buffer does not raise an error
>> if I shrink the frame to a size too small to show all marked files,
>> irrespective of the presence or absence of a header line; in both cases
>> I can shrink the frame until only one file can be shown.
>
> Isn't that what you wanted?
I didn't mean to suggest either behavior was better or worse, I just
wanted to report the observation. But I agree it certainly is better to
have uniform behavior, and no error is fine with me (at least, the
particular error message currently used in the no-header-line case seems
inappropriate).
>> That is, your
>> patch makes the behavior of dired-pop-to-buffer (with my patch)
>> uniformly like the behavior with a header line without your patch. Is
>> that what you intend?
>
> I don't understand what you mean here. What I wanted to resolve in the
> first place was to make `fit-window-to-buffer' not issue an error when
> the frame is to small.
That's exactly what I meant, and my question was just to be sure this
was what you wanted to achieve.
> Is there anything else that doesn't work?
Not with fit-window-to-buffer, AFAICT.
Steve Berman
next prev parent reply other threads:[~2008-12-05 18:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4940E3E8.8050501@gmx.at>
2008-12-04 9:44 ` bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer Stephen Berman
2008-12-04 17:23 ` Drew Adams
2008-12-04 17:58 ` martin rudalics
2008-12-04 18:33 ` martin rudalics
2008-12-05 14:25 ` martin rudalics
2008-12-05 17:27 ` Stephen Berman
2008-12-05 17:37 ` martin rudalics
2008-12-05 18:17 ` Stephen Berman [this message]
2008-12-06 19:25 ` martin rudalics
2008-12-09 20:15 ` Stephen Berman
2008-12-11 17:29 ` martin rudalics
2008-12-11 10:05 ` bug#1488: marked as done (23.0.60; dired-pop-to-buffer: use fit-window-to-buffer) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877i6etrjp.fsf@escher.local.home \
--to=stephen.berman@gmx.net \
--cc=1488@emacsbugs.donarmstrong.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).