From: Juri Linkov <juri@jurta.org>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: 6222@debbugs.gnu.org
Subject: bug#6222: Shouldn't f1 in isearch-mode be help?
Date: Thu, 20 May 2010 03:38:57 +0300 [thread overview]
Message-ID: <877hmz5rn6.fsf@mail.jurta.org> (raw)
In-Reply-To: <AANLkTiloX0dTJ_tF6tEWsCa0HWGq6KUac3_H7qMI8mhh@mail.gmail.com> (Lennart Borgman's message of "Thu, 20 May 2010 02:31:41 +0200")
>> (define-key global-map (char-to-string help-char) 'help-command)
>> (define-key global-map [help] 'help-command)
>> (define-key global-map [f1] 'help-command)
>
> Thanks, I see. But shouldn't isearch do the same then?
I agree that it should:
=== modified file 'lisp/isearch.el'
--- lisp/isearch.el 2010-04-16 01:30:37 +0000
+++ lisp/isearch.el 2010-05-20 00:38:21 +0000
@@ -461,6 +461,9 @@ (defvar isearch-mode-map
(define-key map "\C-y" 'isearch-yank-line)
(define-key map "\C-h" isearch-help-map)
+ (define-key map (char-to-string help-char) isearch-help-map)
+ (define-key map [help] isearch-help-map)
+ (define-key map [f1] isearch-help-map)
(define-key map "\M-n" 'isearch-ring-advance)
(define-key map "\M-p" 'isearch-ring-retreat)
> What about having a function in help.el for defining a binding for all
> three possibilities? Something like
>
> (defun help-define-help-keys (map command)
> (define-key map (char-to-string help-char) command)
> (define-key map [help] command)
> (define-key map [f1] command))
I'd rather remap all them to one key.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2010-05-20 0:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 23:30 bug#6222: Shouldn't f1 in isearch-mode be help? Lennart Borgman
2010-05-20 0:20 ` Juri Linkov
2010-05-20 0:31 ` Lennart Borgman
2010-05-20 0:38 ` Juri Linkov [this message]
2010-05-20 0:47 ` Lennart Borgman
2010-05-20 22:04 ` Juri Linkov
2010-05-20 3:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hmz5rn6.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=6222@debbugs.gnu.org \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).