From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#9361: 24.0.50; default value of `dired-do-chmod' Date: Mon, 12 Sep 2011 16:47:44 -0400 Message-ID: <877h5d1o9b.fsf@stupidchicken.com> References: <03BC028E352D4173B985B3B34DF3193A@us.oracle.com> <87zkiyabea.fsf@mail.jurta.org> <1BDADB23B4434E0C9330F1B010F1E1CE@us.oracle.com> <87bouqlptn.fsf@stupidchicken.com> <87mxea55u8.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315860535 13211 80.91.229.12 (12 Sep 2011 20:48:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Sep 2011 20:48:55 +0000 (UTC) Cc: 'Lars Magne Ingebrigtsen' , 9361@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 12 22:48:47 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R3DQs-0003Sj-OB for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Sep 2011 22:48:46 +0200 Original-Received: from localhost ([::1]:43895 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3DQs-0005Vp-Cq for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Sep 2011 16:48:46 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3DQo-0005Uw-CZ for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2011 16:48:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3DQm-00039Z-2b for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2011 16:48:42 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3DQl-00039J-Ti for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2011 16:48:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R3DV0-0008GC-69; Mon, 12 Sep 2011 16:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2011 20:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 9361-submit@debbugs.gnu.org id=B9361.131586073231683 (code B ref 9361); Mon, 12 Sep 2011 20:53:02 +0000 Original-Received: (at 9361) by debbugs.gnu.org; 12 Sep 2011 20:52:12 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R3DUB-0008Ey-Ts for submit@debbugs.gnu.org; Mon, 12 Sep 2011 16:52:12 -0400 Original-Received: from vm-emlprdomr-02.its.yale.edu ([130.132.50.143]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R3DU9-0008Er-S2 for 9361@debbugs.gnu.org; Mon, 12 Sep 2011 16:52:10 -0400 Original-Received: from furball (dhcp-128-36-14-41.central.yale.edu [128.36.14.41]) (authenticated bits=0) by vm-emlprdomr-02.its.yale.edu (8.14.4/8.14.4) with ESMTP id p8CKliW3021333 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 12 Sep 2011 16:47:45 -0400 In-Reply-To: <87mxea55u8.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 12 Sep 2011 14:49:23 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.143 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 12 Sep 2011 16:53:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51077 Archived-At: Juri Linkov writes: >> I think there's a problem here, indeed. It's a bad idea to take an >> empty input to mean a certain default permission---especially when that >> default permission is not displayed in the prompt. >> >> The following patch makes dired-do-chmod demand a non-empty input. The >> precomputed permission is still available in the M-n `future history'. > > There are other demands that dired commands should not use `read-string' > that returns the default value for an empty input. Please see > http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg01200.html > > So we should either change `read-string' (backward-incompatible change) > or to change `dired-mark-read-string' not to use `read-string'. I fixed up `dired-mark-read-string'; that's much safer, since there are only three callers to worry about.