unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Julien Danjou <julien@danjou.info>
Cc: 9581@debbugs.gnu.org
Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil
Date: Sat, 24 Sep 2011 16:37:29 +0200	[thread overview]
Message-ID: <877h4yc8gm.fsf@gmx.de> (raw)
In-Reply-To: <87wrcydnuq.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Sat, 24 Sep 2011 16:19:41 +0200")

Julien Danjou <julien@danjou.info> writes:

> The patch is not enough. It fixes the precise case I reported, but this
> fails now:
>
> (setq db
>       (dbus-register-signal :session "some.service"
>                             "/org/gtk/Private/RemoteVolumeMonitor"
>                             "org.gtk.Private.RemoteVolumeMonitor" "VolumeAdded"
>                             'identity))
> (dbus-unregister-object db)

I've played exactly this example (replacing "some.service" by
"org.gtk.Private.GduVolumeMonitor" in order to have an existing
service). No problem.

> Debugger entered--Lisp error: (dbus-error "Match rule has a key with no subsequent '=' character")
>   dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus" "org.freedesktop.DBus" "RemoveMatch" "Z")

Where does the "Z" comes from? There will never be such a rule, added by
AddMatch.

Did you compile also dbusbind.c before testing?

Could you apply (dbus-list-hash-table) before calling
`dbus-unregister-object', and show the result?

>> Reading the code, `dbus-registered-objects-table' has become an
>> unreadable format. Maybe we shall redesign the format, and move most of
>> the functionality from dbusbind.c to dbus.el. But that's something for
>> after-the-release.
>
> I totally agree with that. It needs to be reworked. :)

I'll prepare a patch. Locally, there are already some of them waiting
for after-the-release.

Best regards, Michael.





  reply	other threads:[~2011-09-24 14:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22 23:01 bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Julien Danjou
2011-09-23 15:37 ` Michael Albinus
2011-09-23 16:12   ` Julien Danjou
2011-09-24 11:50     ` Michael Albinus
2011-09-24 14:19       ` Julien Danjou
2011-09-24 14:37         ` Michael Albinus [this message]
2011-09-25 11:38           ` Julien Danjou
2011-09-25 11:59             ` Michael Albinus
2011-09-25 12:19               ` Julien Danjou
2011-09-25 16:03                 ` Michael Albinus
2011-09-26 12:16                   ` Julien Danjou
2011-09-26 13:57                     ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877h4yc8gm.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=9581@debbugs.gnu.org \
    --cc=julien@danjou.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).