From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9185: 24.0.50; "C-s M-p" does not bring the tip of the search ring Date: Sat, 19 Nov 2011 21:59:58 +0200 Organization: JURTA Message-ID: <877h2vrigx.fsf@mail.jurta.org> References: <87livig3cr.fsf@mail.jurta.org> <87r55aenuc.fsf@mail.jurta.org> <87oc0c176d.fsf@mail.jurta.org> <87fwkuppz3.fsf@mail.jurta.org> <8739gtg0wp.fsf@mail.jurta.org> <87liukxxtj.fsf@mail.jurta.org> <87ei0aizl8.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1321732928 27389 80.91.229.12 (19 Nov 2011 20:02:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 19 Nov 2011 20:02:08 +0000 (UTC) To: 9185@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 19 21:02:04 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRr6x-0000CB-UP for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Nov 2011 21:02:04 +0100 Original-Received: from localhost ([::1]:41659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRr6x-0003aA-EM for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Nov 2011 15:02:03 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:40070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRr6t-0003Zk-Qe for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2011 15:02:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRr6s-0007rg-RF for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2011 15:01:59 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRr6s-0007rc-OT for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2011 15:01:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RRr7u-0001Gz-8Q for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2011 15:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Nov 2011 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9185 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9185-submit@debbugs.gnu.org id=B9185.13217329344838 (code B ref 9185); Sat, 19 Nov 2011 20:03:02 +0000 Original-Received: (at 9185) by debbugs.gnu.org; 19 Nov 2011 20:02:14 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRr77-0001Fz-Gc for submit@debbugs.gnu.org; Sat, 19 Nov 2011 15:02:14 -0500 Original-Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRr75-0001Fr-1E for 9185@debbugs.gnu.org; Sat, 19 Nov 2011 15:02:12 -0500 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 470816E80A9 for <9185@debbugs.gnu.org>; Sat, 19 Nov 2011 12:01:06 -0800 (PST) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id EAFC9451C5FA for <9185@debbugs.gnu.org>; Sat, 19 Nov 2011 12:01:03 -0800 (PST) In-Reply-To: <87ei0aizl8.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 24 Aug 2011 18:44:19 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 19 Nov 2011 15:03:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54065 Archived-At: >> But I've found another use-case that seems to need a fix too: >> 0. C-s a C-s b C-s c >> 1. C-s C-s --> "c" is selected, OK. >> 2. M-p --> "b" is selected, OK. >> 3. M-p --> Now "c" (the previous used entry) should have been >> selected, but I see that "b" (the current entry) remains selected >> instead. > > This is a separate problem caused when exiting from the minibuffer in > `isearch-edit-string' by `read-from-minibuffer' (i.e. step 2 > `M-p ' above) adds a new element "b" to the history (search ring). > > I agree that `isearch-edit-string' should not update the search ring. > It should be updated only by `isearch-update-ring' in `isearch-done'. > So e.g. `C-s C-s M-e RET C-g' or `C-s M-p RET C-g' should keep the > search ring unchanged. Note also that `isearch-done' with the arg > NOPUSH=t already tries to take care of not updating the search ring, > but unsuccessfully. It requires the following patch for the complete fix: I noticed now that `isearch-edit-string' should not add new elements to the search ring, but should allow old elements to be deleted from the search ring with a command like `delete-history-element' (published in http://thread.gmane.org/gmane.emacs.devel/24353/focus=25269) So I installed another fix that let-binds `history-add-new-input' to nil.