bug#10694: [Ivan Kanis] pretest 24.0.93 failure

bug#10694: [Ivan Kanis] pretest 24.0.93 failure

[Chong Yidong]

[-- Attachment #0: Type: message/rfc822, Size: 8047 bytes --]

[-- Attachment #1.1: Type: text/plain, Size: 206 bytes --]

Hi,

It doesn't compile on OSX 10.4 with XCode 2.5. I have attached the error
log.

Take care,
-- 
Ivan Kanis
http://kanis.fr

Let a fool hold his tongue and he will pass for a sage.
    -- Publilius Syrus

[-- Attachment #1.2: err.log --]
[-- Type: application/octet-stream, Size: 3081 bytes --]

[ -r "/Users/ivan/src/emacs-24.0.93/src/config.in" ] || ( cd /Users/ivan/src/emacs-24.0.93 && autoheader )
cd lib; make all                            \
  CC='gcc -std=gnu99 -I/sw/include -L/sw/lib' CFLAGS='-g' CPPFLAGS='' \
  LDFLAGS='' MAKE='make'
make  all-am
make[2]: Nothing to be done for `all-am'.
cd lib-src; make all                            \
  CC='gcc -std=gnu99 -I/sw/include -L/sw/lib' CFLAGS='-g' CPPFLAGS='' \
  LDFLAGS='' MAKE='make'
make[1]: Nothing to be done for `all'.
boot=bootstrap-emacs;                         \
if [ ! -x "src/$boot" ]; then                                     \
    cd src; make all                                    \
      CC='gcc -std=gnu99 -I/sw/include -L/sw/lib' CFLAGS='-g' CPPFLAGS=''         \
      LDFLAGS='' MAKE='make' BOOTSTRAPEMACS="$boot"; \
fi;
gcc -std=gnu99 -I/sw/include -L/sw/lib -c  -Demacs -DHAVE_CONFIG_H  -I. -I/Users/ivan/src/emacs-24.0.93/src -I../lib -I/Users/ivan/src/emacs-24.0.93/src/../lib   -I/usr/X11R6/include            -MMD -MF deps/nsterm.d -MP   -Wimplicit-function-declaration -Wold-style-definition -Wdeclaration-after-statement  -g  nsterm.m
nsterm.m: In function 'ns_lisp_to_color':
nsterm.m:1555: warning: pointer targets in passing argument 1 of 'ns_get_color' differ in signedness
nsterm.m:1557: warning: pointer targets in passing argument 1 of 'ns_get_color' differ in signedness
nsterm.m: In function 'ns_string_to_lispmod':
nsterm.m:3777: warning: pointer targets in passing argument 1 of 'strncmp' differ in signedness
nsterm.m:3779: warning: pointer targets in passing argument 1 of 'strncmp' differ in signedness
nsterm.m:3781: warning: pointer targets in passing argument 1 of 'strncmp' differ in signedness
nsterm.m:3783: warning: pointer targets in passing argument 1 of 'strncmp' differ in signedness
nsterm.m:3785: warning: pointer targets in passing argument 1 of 'strncmp' differ in signedness
nsterm.m:3787: warning: pointer targets in passing argument 1 of 'strncmp' differ in signedness
nsterm.m: In function 'ns_term_init':
nsterm.m:4070: warning: pointer targets in passing argument 2 of 'strncpy' differ in signedness
nsterm.m:4114: warning: pointer targets in assignment differ in signedness
nsterm.m:4205: error: 'NSMenuDidBeginTrackingNotification' undeclared (first use in this function)
nsterm.m:4205: error: (Each undeclared identifier is reported only once
nsterm.m:4205: error: for each function it appears in.)
nsterm.m: In function 'ns_term_shutdown':
nsterm.m:4226: warning: pointer targets in passing argument 1 of 'unlink' differ in signedness
nsterm.m: In function '-[EmacsApp requestService:userData:error:]':
nsterm.m:4573: warning: pointer targets in passing argument 1 of 'stringWithUTF8String:' differ in signedness
nsterm.m: In function '-[EmacsView initFrameFromEmacs:]':
nsterm.m:5520: warning: pointer targets in passing argument 1 of 'stringWithUTF8String:' differ in signedness
nsterm.m:5539: warning: pointer targets in passing argument 1 of 'stringWithUTF8String:' differ in signedness
make[1]: *** [nsterm.o] Error 1
make: *** [src] Error 2

bug#10694: [Ivan Kanis] pretest 24.0.93 failure

[Chong Yidong]

> It doesn't compile on OSX 10.4 with XCode 2.5. I have attached the
> error log.

Does the following patch do the right thing?  (Completely untested.)

=== modified file 'src/nsterm.m'
*** src/nsterm.m	2012-01-31 03:07:38 +0000
--- src/nsterm.m	2012-02-02 05:18:55 +0000
***************
*** 64,69 ****
--- 64,70 ----
  #define NSTRACE(x)
  #endif
  
+ extern NSString *NSMenuDidBeginTrackingNotification;
  
  /* ==========================================================================
  

bug#10694: [Ivan Kanis] pretest 24.0.93 failure

[Ivan Kanis]

Chong Yidong <cyd@gnu.org> wrote:

>> It doesn't compile on OSX 10.4 with XCode 2.5. I have attached the
>> error log.
>
> Does the following patch do the right thing?  (Completely untested.)

Yup it does the right thing, thanks!
-- 
Ivan Kanis
http://kanis.fr

We know what we are, but know not what we may be.
    -- William Shakespeare

bug#10694: [Ivan Kanis] pretest 24.0.93 failure

[Ivan Kanis]

Chong Yidong <cyd@gnu.org> wrote:

>> It doesn't compile on OSX 10.4 with XCode 2.5. I have attached the
>> error log.
>
> Does the following patch do the right thing?  (Completely untested.)

Yup it does the right thing, thanks!
-- 
Ivan Kanis
http://kanis.fr

We know what we are, but know not what we may be.
    -- William Shakespeare