bug#11251: Use -Wl,-rpath instead of -R on GNU/Linux with GCC 4.6

bug#11251: Use -Wl,-rpath instead of -R on GNU/Linux with GCC 4.6

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 86 bytes --]

Hello,

The patch below fixes linking of ‘temacs’ on GNU/Linux with GCC 4.6.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 577 bytes --]

=== modified file 'configure.in'
--- configure.in	2011-09-26 18:38:31 +0000
+++ configure.in	2012-04-16 09:52:23 +0000
@@ -3406,7 +3406,7 @@ case "$opsys" in
   ## had not yet been defined and was expanded to null.  Hence LD_SWITCH_SYSTEM
   ## had different values in configure (in ac_link) and src/Makefile.in.
   ## It seems clearer therefore to put this piece in LD_SWITCH_SYSTEM_TEMACS.
-  gnu-linux) LD_SWITCH_SYSTEM_TEMACS="\$(LD_SWITCH_X_SITE_AUX)" ;;
+  gnu-linux) LD_SWITCH_SYSTEM_TEMACS="\$(LD_SWITCH_X_SITE_AUX_RPATH)" ;;
 
   *) LD_SWITCH_SYSTEM_TEMACS= ;;
 esac


[-- Attachment #3: Type: text/plain, Size: 803 bytes --]


GCC 4.5 used to ignore ‘-R’, but GCC 4.6 rejects it:

--8<---------------cut here---------------start------------->8---
$ echo "int main () { return 0; }" > t.c

$ ./result/bin/gcc t.c -R/foo
gcc: unrecognized option '-R/foo'
$ echo $?
0
$ ./result/bin/gcc --version | head -1
gcc (GCC) 4.5.3

$ gcc t.c -R/foo
gcc: error: unrecognized option ‘-R’
$ echo $?
1
$ gcc --version | head -1
gcc (GCC) 4.6.2
--8<---------------cut here---------------end--------------->8---

(This is why the ‘build’ job at <http://hydra.nixos.org/eval/605870> has
been failing since the standard build environment switched from GCC 4.5
to 4.6 last month.)

In fact, the above should be applied to all GNU variants, so *gnu* may
be more appropriate than gnu-linux.

Thanks,
Ludo’.

bug#11251: Use -Wl, -rpath instead of -R on GNU/Linux with GCC 4.6

[Chong Yidong]

ludo@gnu.org (Ludovic Courtès) writes:

> The patch below fixes linking of ‘temacs’ on GNU/Linux with GCC 4.6.

Thanks.  I guess we'll have to put this in the emacs-24 brach.  It's
late in the pretest, but that can't be helped.  Does anyone see any
problem with the patch?


(BTW, maybe we don't need to AC_SUBST the LD_SWITCH_X_SITE_AUX and
LD_SWITCH_X_SITE_AUX_RPATH variables; they don't seem to be used
anywhere outside of configure.)

bug#11251: Use -Wl, -rpath instead of -R on GNU/Linux with GCC 4.6

[Glenn Morris]

Chong Yidong wrote:

> (BTW, maybe we don't need to AC_SUBST the LD_SWITCH_X_SITE_AUX and
> LD_SWITCH_X_SITE_AUX_RPATH variables; they don't seem to be used
> anywhere outside of configure.)

Yes they are. Eg

case "$opsys" in
  netbsd|openbsd)
   LD_SWITCH_SYSTEM="\$(LD_SWITCH_X_SITE_AUX_RPATH) $LD_SWITCH_SYSTEM"
  ;;
esac

Note escaped \$, so these references appear in the Makefile unexpanded.

bug#11251: Use -Wl, -rpath instead of -R on GNU/Linux with GCC 4.6

[Chong Yidong]

ludo@gnu.org (Ludovic Courtès) writes:

> The patch below fixes linking of ‘temacs’ on GNU/Linux with GCC 4.6.

Committed to the emacs-24 branch.  Thanks.