unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#7065: 24.0.50; fringe values broken, doc incorrect
@ 2010-09-18 14:50 Drew Adams
  2014-02-09  7:02 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2010-09-18 14:50 UTC (permalink / raw)
  To: 7065

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-09-06 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'

From bug #6933:

> > Can we settle this?
> 
> Feel free to submit a separate bug report.  I'm not going to do
> anything about this at this time, for the reasons stated above.

So here's the new bug report.  See #6933 for more context and history.

> > What about the confusing name `default' and the doc?
> 
> The original bug report was only about the effect of `half'.
> Documentation is an unrelated issue.

See my second mail for bug #6933, which clarifies things.
I specifically mention problems with the doc and with `default'.

> I don't see a good reason for renaming the symbolic values.

They don't do what they say.  `half' is not necessarily half of `default', even
when one disregards rounding.  `default' itself is a misleading name.  The ELisp
manual calls it "standard", but even that is not great.  Apparently it is the
full width needed to display all fringe bitmaps.  If we kept a symbolic value
for this it should be something like `full'.

> Doing so will surely cause back-compatibility issues,

It is used only in interactive interfaces.

> so IMO we need a really good reason for such a change.
> 
> > "standard fringe width, which is the width needed to 
> > display the fringe bitmaps"
> >
> > That suggests that it is a function of the fringe bitmaps, 
> > not a constant width.
> 
> They are constant for the time being, but may change in the future,
> e.g. if we lift the current restriction of the display engine that
> limits window width to an integral multiple of the canonical character
> size.

We don't name things based on such maybe-one-day-everything-will-be-different
imaginings.  These names have long (years) been giving the wrong impression.

> > But as I say, if `default' and `half' are, in their effect, 
> > just hard-coded numeric widths, then let's get rid of those
> > value-menu and `interactive' spec choices.  There is no need for a
> > value of nil unless it actually does let the
> > fringe be different in different contexts (e.g. bitmap size).
> 
> I don't think it's right to fix the choices on specific numbers.
> Symbolic values allow us to change the underlying implementation in
> the future without hurting compatibility.

See above. The choices that users have should reflect the actual behavior, not
some imagined future behavior.  The only real behaviors possible today and
forever into the past are fixed numeric values for left, right, or both.  The UI
should reflect that faithfully.  It should not be a UI for some imagined
alternative or future world.

> The fact that some of the documentation describes the current
> implementation is not necessarily a good reason to remove future
> extensibility.

The doc and UI should reflect the product's behavior, not some alternative
behavior some developer might be dreaming of.  That's a no-brainer.






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#7065: 24.0.50; fringe values broken, doc incorrect
  2010-09-18 14:50 bug#7065: 24.0.50; fringe values broken, doc incorrect Drew Adams
@ 2014-02-09  7:02 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-09  7:02 UTC (permalink / raw)
  To: Drew Adams; +Cc: 7065

"Drew Adams" <drew.adams@oracle.com> writes:

> They don't do what they say.  `half' is not necessarily half of
> `default', even when one disregards rounding.  `default' itself is a
> misleading name.  The ELisp manual calls it "standard", but even that
> is not great.  Apparently it is the full width needed to display all
> fringe bitmaps.  If we kept a symbolic value for this it should be
> something like `full'.

I think `default' is a fine name, and `half-width' now really is half
width.  Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-09  7:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-18 14:50 bug#7065: 24.0.50; fringe values broken, doc incorrect Drew Adams
2014-02-09  7:02 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).