From: "Alex Bennée" <kernel-hacker@bennee.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 16599@debbugs.gnu.org, "Alex Bennée" <kernel-hacker@bennee.com>,
emacs-devel@gnu.org
Subject: bug#16599: src/temacs --daemon fails
Date: Mon, 17 Feb 2014 07:40:35 +0000 [thread overview]
Message-ID: <877g8unq4s.fsf__39545.5707599924$1392622887$gmane$org@bennee.com> (raw)
In-Reply-To: <871tz2iuuu.fsf@igel.home>
Andreas Schwab <schwab@linux-m68k.org> writes:
> Alex Bennée <kernel-hacker@bennee.com> writes:
>
>> diff --git a/src/emacs.c b/src/emacs.c
>> index 18f6a08..66f47ef 100644
>> --- a/src/emacs.c
>> +++ b/src/emacs.c
>> @@ -201,7 +201,7 @@ static char *daemon_name;
>>
>> /* Pipe used to send exit notification to the daemon parent at
>> startup. */
>> -int daemon_pipe[2];
>> +int daemon_pipe[2] = {0, 0};
>
> This is redundant.
Indeed. I wasn't sure if the code I replaced relied on some special
difference between .data and .bss sections. I have to admit I'm
unfamiliar with how the Emacs dumping mechanism works.
Why did the syms_of_emacs() function feel the need to initialise daemon_pipe?
>
> Andreas.
--
Alex Bennée
next prev parent reply other threads:[~2014-02-17 7:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bnyt5zmi.fsf@linaro.org>
[not found] ` <83k3dh7837.fsf@gnu.org>
2014-02-16 21:34 ` bug#16599: src/temacs --daemon fails Alex Bennée
2014-02-16 21:57 ` Andreas Schwab
[not found] ` <871tz2iuuu.fsf@igel.home>
2014-02-17 7:40 ` Alex Bennée [this message]
[not found] ` <877g8unq4s.fsf@bennee.com>
2014-02-17 15:51 ` Eli Zaretskii
2014-02-17 16:03 ` Andreas Schwab
2014-02-17 16:15 ` Eli Zaretskii
2014-02-17 16:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='877g8unq4s.fsf__39545.5707599924$1392622887$gmane$org@bennee.com' \
--to=kernel-hacker@bennee.com \
--cc=16599@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).