From: joaotavora@gmail.com (João Távora)
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 16981@debbugs.gnu.org, Alan Mackenzie <acm@muc.de>
Subject: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others
Date: Sun, 06 Apr 2014 02:51:07 +0100 [thread overview]
Message-ID: <877g738buc.fsf@kitaj.lan> (raw)
In-Reply-To: <jwvioqnpzdg.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Sat, 05 Apr 2014 11:45:09 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>>> There's something funny going on here. A minor mode's keymap should
>> You're right, but I can't figure out what.
> That's because it's how remapping is works: first we lookup the key
> So the local-map and global-map's normal bindings take precedence over the
> minor-map's remapping.
Yeah that's it I remembered that this afternoon.
> (define-key electric-pair-mode-map "\177"
> `(menu-item "" electric-pair-delete-pair
> :filter
> electric-pair-delete-adjacent-pairs)
> cmd))))))
Aha, the famed :filter trick I had heard about. Looks good enough while
we wait for that multiple-commands-per-keybinding refactoring. Not as
clean as remapping, but probably good enough, and it's arguable we want
this on any other key than backspace.
Hmmm now I remember that's it's even harder than defadvice to find the
extra code, docstring-wise I mean. How would a hacker discover we're
using the filter trick. describe-key doesn't help. .
Anyway should I install it? To emacs-24 only? I need a little help
VC-wise:
- I got two commits that are in trunk, r116926 and r116940, and should
be in (cherry-picked to?) emacs-24
- Three different fixes (bugs 16981,17192 and 17183) not yet pushed that
I think you want me to only push to emacs-24, since that will be merged
back to trunk later.
Is this correct? I also don't know much bzr to do this, especially the
first item. Is there a wiki as clear as BzrForEmacsDevs on this
particular workflow? I just did a "bzr switch emacs-24" from what I
believe to be a heavyweight checkout or something. It seems to have
worked.
next prev parent reply other threads:[~2014-04-06 1:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.16921.1394480964.10748.bug-gnu-emacs@gnu.org>
2014-03-10 19:47 ` bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others João Távora
2014-03-13 22:04 ` Alan Mackenzie
2014-03-18 1:56 ` bug#16959: " Stefan
2014-03-20 0:33 ` Florian Beck
2014-03-21 21:47 ` Stefan
2014-03-25 17:38 ` Florian Beck
2014-03-26 0:34 ` Stefan Monnier
2014-04-05 11:58 ` João Távora
2014-04-05 15:45 ` Stefan Monnier
2014-04-06 1:51 ` João Távora [this message]
2014-04-06 12:48 ` Stefan Monnier
2014-04-06 15:08 ` João Távora
2014-04-07 0:04 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g738buc.fsf@kitaj.lan \
--to=joaotavora@gmail.com \
--cc=16981@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).