From: Michael Albinus <michael.albinus@gmx.de>
To: Ken Brown <kbrown@cornell.edu>
Cc: 20118@debbugs.gnu.org
Subject: bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin
Date: Tue, 17 Mar 2015 11:36:41 +0100 [thread overview]
Message-ID: <877fufq5ae.fsf@gmx.de> (raw)
In-Reply-To: <55079001.6080401@cornell.edu> (Ken Brown's message of "Mon, 16 Mar 2015 22:22:57 -0400")
Ken Brown <kbrown@cornell.edu> writes:
>>> The outward symptom is almost identical to that of Bug#20117, but I
>>> don't know if the present bug is related, because it's been happening
>>> for as long as I can remember; I just never got around to reporting it.
>>>
>>> Test tramp-test29-vc-registered aborted with non-local exit
>>> ABORTED 30/41 tramp-test29-vc-registered
>>
>> Please instrument it similar to the recipe in bug#20117.
>
> Output attached.
Well, this bug is different from Bug#20117. A shell function Tramp sends
to the remote host contains some lines with leading TABs. Your bash tries
to expand them.
The following patch shall fix this.
--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/tramp/lisp/tramp-sh.el.~master~ 2015-03-17 11:25:13.857882111 +0100
--- /home/albinus/src/tramp/lisp/tramp-sh.el 2015-03-17 11:24:45.233315481 +0100
***************
*** 3725,3730 ****
--- 3725,3734 ----
(tramp-get-connection-process vec) "scripts" nil)))
(unless (member name scripts)
(with-tramp-progress-reporter vec 5 (format "Sending script `%s'" name)
+ ;; In bash, leading TABs like in `tramp-vc-registered-read-file-names'
+ ;; could result in unwanted command expansion. Avoid this.
+ (setq script (tramp-compat-replace-regexp-in-string
+ (make-string 1 ?\t) (make-string 8 ? ) script))
;; The script could contain a call of Perl. This is masked with `%s'.
(when (and (string-match "%s" script)
(not (tramp-get-remote-perl vec)))
--8<---------------cut here---------------end--------------->8---
> Ken
Best regards, Michael.
next prev parent reply other threads:[~2015-03-17 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:59 bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin Ken Brown
2015-03-16 18:49 ` Michael Albinus
2015-03-17 2:22 ` Ken Brown
2015-03-17 10:36 ` Michael Albinus [this message]
2015-03-17 13:05 ` Ken Brown
2015-03-17 19:09 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fufq5ae.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=20118@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).