From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#12939: 24.3.50; [PATCH] `icomplete-mode' should respect `completion-ignored-extensions' Date: Thu, 28 Apr 2016 19:31:59 +0200 Message-ID: <877ffh7i7k.fsf@gnus.org> References: <0698DAE413DC4AF9827C54F4C6206C07@us.oracle.com> <87k2luejeq.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461864805 20940 80.91.229.3 (28 Apr 2016 17:33:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Apr 2016 17:33:25 +0000 (UTC) Cc: 12939@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 28 19:33:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avpoM-0007ws-3F for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 19:33:10 +0200 Original-Received: from localhost ([::1]:50356 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avpoL-0003PH-HL for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 13:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avpoH-0003Mx-E1 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:33:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avpoE-0008OW-NZ for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avpoE-0008OQ-Kd for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1avpoE-000050-C9 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2016 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12939 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12939-submit@debbugs.gnu.org id=B12939.146186472332694 (code B ref 12939); Thu, 28 Apr 2016 17:33:02 +0000 Original-Received: (at 12939) by debbugs.gnu.org; 28 Apr 2016 17:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:53495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avpnH-0008VG-MJ for submit@debbugs.gnu.org; Thu, 28 Apr 2016 13:32:03 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:32971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avpnG-0008Uz-MR for 12939@debbugs.gnu.org; Thu, 28 Apr 2016 13:32:03 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avpnE-0005dL-61; Thu, 28 Apr 2016 19:32:02 +0200 In-Reply-To: (Drew Adams's message of "Wed, 24 Feb 2016 07:10:22 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117106 Archived-At: Drew Adams writes: >> > `icomplete-mode' shows, e.g., names of files ending with `~'. It >> > should, but it does not, respect `completion-ignored-extensions'. >> > >> > This is apparently because `completion-all-sorted-completions' >> > does not respect it either (which is, however, TRT). >> >> You included an entire version of icomplete.el, which, of course, >> can't be compared for code changes now. >> >> Could you submit a patch for the changes you want to see happen? > > I meant to send the attached 2012 patch; sorry. Of course, you might > need to adjust something because the code base has probably changed > a bit since 2012. ;-) Looks fine; applied to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no