From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#18587: 24.4.50; error from cl-assert with a symbol argument Date: Sun, 03 Jul 2016 23:53:15 -0400 Message-ID: <877fd2dpp0.fsf@users.sourceforge.net> References: <87k34lfy8x.fsf@tromey.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1467604467 27739 80.91.229.3 (4 Jul 2016 03:54:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Jul 2016 03:54:27 +0000 (UTC) Cc: 18587@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 04 05:54:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bJuxb-0002n4-78 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2016 05:54:15 +0200 Original-Received: from localhost ([::1]:45071 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJuxZ-0004SO-T4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 23:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJuxU-0004R5-1j for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 23:54:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJuxP-0000qA-0l for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 23:54:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJuxO-0000q5-TY for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 23:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bJuxO-0006eO-Gm for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 23:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2016 03:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18587-submit@debbugs.gnu.org id=B18587.146760439725503 (code B ref 18587); Mon, 04 Jul 2016 03:54:02 +0000 Original-Received: (at 18587) by debbugs.gnu.org; 4 Jul 2016 03:53:17 +0000 Original-Received: from localhost ([127.0.0.1]:36410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJuwe-0006dC-Qh for submit@debbugs.gnu.org; Sun, 03 Jul 2016 23:53:16 -0400 Original-Received: from mail-io0-f171.google.com ([209.85.223.171]:35412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJuwc-0006cu-EC; Sun, 03 Jul 2016 23:53:15 -0400 Original-Received: by mail-io0-f171.google.com with SMTP id f30so143056618ioj.2; Sun, 03 Jul 2016 20:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rRjgsfL51GrFJBX0xhifYJ/qy3bQIzBVWkBzSeO9pnQ=; b=L3EuaefN/emLY55eq92ikxy1IgoBFseRV7S47T/mXOShbM+/7S5+nOzr0tfkTOEDyX rb5C2wz3F7jFlQ/f9gF2UGBt2bQXBbd+lJKdRh7SPIgoISLpjL9q428mj9c1GZQL3Ayq 72MDPk8My/K/A2gBIVHceFNckFxZjA2yf4vYcFl1PxglQAqlM0L3HeGLdbWSU2/skZyt 5KmIkB4sUG++6FCPYxAIkoTpsyHF6zlPk9KORulcOyEopeEvpZ4BDCd+hzoGmP0Ix0wa KhY6M6E/MnZ3NYuOYkLcZSB6u8IUDBBWlq3ZQZhCGz+zLtenNzJRl0ZREdAPoe1gxmEd 6slQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=rRjgsfL51GrFJBX0xhifYJ/qy3bQIzBVWkBzSeO9pnQ=; b=H6QXi7r1GuGhEeHUsDGlxF5enO2Y7Y0z18zlzs1qGEp3u2RoeXoJUhRVFhxqlCDwYp RrkGvV2keEwBomelWT8m6iRk2KnhpGr7QYe40OJS8Qe75fONpTu4PQypXCRuoltaJ4hE 6Y/dOTqGfgwX/DrDMLRHz4clI9CTbQdQP6vz8bpy4f37/pUcU3wHmzv4/11ZNRBOUg/G J7ilxwbWbo4QkQGJr9lbXvyqe9AUu6jqyBImP5rSqsjxrLjqvYSQNZ74asDA2lnBgIto uhszSHKjn0+3K/TE+Y8BARi3msrlIVhZhNA52Sestoht+3rEgDn3AHzbb3hJRIqEfeF9 jfpA== X-Gm-Message-State: ALyK8tJOEz9Eqd/oHR0NU5p1rUDlbZxg2CYKEhCqDH4FLzDoQTLK4sAc9XctFMZ2n0uFwg== X-Received: by 10.107.20.10 with SMTP id 10mr7085842iou.15.1467604388761; Sun, 03 Jul 2016 20:53:08 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id g11sm1007236iod.41.2016.07.03.20.53.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jul 2016 20:53:08 -0700 (PDT) In-Reply-To: <87k34lfy8x.fsf@tromey.com> (Tom Tromey's message of "Tue, 30 Sep 2014 06:55:42 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120383 Archived-At: --=-=-= Content-Type: text/plain severity 18587 minor tags 18587 patch quit Tom Tromey writes: > This works fine: > > (let ((x 5)) > (cl-assert x)) > > However, to my surprise, this fails with an error from macroexpand: > > (let ((x 5)) > (cl-assert x t)) > > Writing (cl-assert (progn x) t) works ok, but I think ideally I > shouldn't have to do that. Yeah, seems kind of silly. Here's a patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Fix-cl-assert-with-atomp-FORM-non-nil-SHOW-ARGS.patch Content-Description: patch >From b0fbb6f88c09e13977dca1d24ef76e40312fe4b5 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 3 Jul 2016 23:44:14 -0400 Subject: [PATCH v1] Fix cl-assert with atomp FORM, non-nil SHOW-ARGS * lisp/emacs-lisp/cl-macs.el (cl-assert): Don't require that FORM is a list when showing its (non-existent) arguments. --- lisp/emacs-lisp/cl-macs.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index d2c90c2..b12c8bf 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -2978,7 +2978,7 @@ cl-assert (delq nil (mapcar (lambda (x) (unless (macroexp-const-p x) x)) - (cdr form)))))) + (cdr-safe form)))))) `(progn (or ,form (cl--assertion-failed -- 2.8.0 --=-=-=--