From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Wed, 20 Jul 2016 23:00:59 -0400 Message-ID: <877fcfd79w.fsf@users.sourceforge.net> References: <87vb066ejv.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> <83shv4z7e8.fsf@gnu.org> <83inw0yw9q.fsf@gnu.org> <87bn1rdd1f.fsf@users.sourceforge.net> <83h9bjzp5i.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469070147 26553 80.91.229.3 (21 Jul 2016 03:02:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 03:02:27 +0000 (UTC) Cc: nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, monnier@iro.umontreal.ca, alex.bennee@linaro.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 21 05:02:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQ4Fb-0008O9-8S for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 05:02:15 +0200 Original-Received: from localhost ([::1]:37986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ4Fa-0001LL-Bm for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 23:02:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ4FS-0001LD-UY for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 23:02:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQ4FO-00026K-Q5 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 23:02:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ4FO-00026G-Me; Wed, 20 Jul 2016 23:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQ4FO-0007CM-8S; Wed, 20 Jul 2016 23:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Thu, 21 Jul 2016 03:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.146907006727608 (code B ref 23917); Thu, 21 Jul 2016 03:02:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 21 Jul 2016 03:01:07 +0000 Original-Received: from localhost ([127.0.0.1]:59152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ4EV-0007BE-CN for submit@debbugs.gnu.org; Wed, 20 Jul 2016 23:01:07 -0400 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:32799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ4ER-0007Ac-C7 for 23917@debbugs.gnu.org; Wed, 20 Jul 2016 23:01:05 -0400 Original-Received: by mail-it0-f54.google.com with SMTP id f6so877828ith.0 for <23917@debbugs.gnu.org>; Wed, 20 Jul 2016 20:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=m/lEXf/iA9czPXxyHY+moOFGN7fLdFrRuT5wR1IfMpE=; b=ylIamaj0wdsZvOYHg6YkNiXrg1XawhZxAvO7hCPU+1GEURvRIQbD605vqOAwIE2YK3 kUE4msHKDGtFlntTY4nONMWE32XQy9OqKYwjs9gfSAaWkBk8p8B8zlVHD5whCmZFYeGs kiB5ygYwi6frLo15iAd+F8AAzh8UYRrTMePoz56w++MnUWNPf5MRD8lternweLSJpR9q 18WzfSEexOI4KAFxCFgFZQ4RDKuyNs9H8HWxUceWzlf7Oow8XHlklomYWwCgLynEgqe4 FgBvpZkpnBeZWi6wPDpMdIDXlrxqeCmHN2krwDuhSJd4UliNQupGFHd0X+gTcoWAXzkG /img== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=m/lEXf/iA9czPXxyHY+moOFGN7fLdFrRuT5wR1IfMpE=; b=iHCtYodumNK/vP8CvNztB7+/BOFnRWSmbHYQbgtS/eL1Vb6ylyOZidY9E39OwkPQYp 7Rn1MV9UiSY6zq0aviiiaOxZiDZ5HKexIORX205c90LGv2fVzMzbeJ6NioN2gPTrsXmY 3o3IQVHdoc7694dBBKmdw5kPzAc6dpHwnqx/+gy2oIo6SdcRk7y3raG2vMQeu4L2mBIb 0/Ie2pak8/AsiugWbnE1TLEtNC6ZAtaxh1GSmGGEVwpYMhsR34nDxleQV6bJZDCUBO0G 2EjtSLS3vM/alrgd2Qh8Fp+jwadPjjTQ+zy/J4KCrc11fUsj1v35g/2X44QgZZZ9ebaG xcxg== X-Gm-Message-State: ALyK8tLeC7kHAnLfCoJlxeJ0BXbSEZLmKgnz0dRxJieezkM2lsflYKnYIgirTutGpSIyAg== X-Received: by 10.36.192.9 with SMTP id u9mr6104268itf.86.1469070057871; Wed, 20 Jul 2016 20:00:57 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id q1sm504318itb.2.2016.07.20.20.00.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jul 2016 20:00:57 -0700 (PDT) In-Reply-To: <83h9bjzp5i.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Jul 2016 05:43:53 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121356 Archived-At: Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Cc: Eli Zaretskii , 23917@debbugs.gnu.org, nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, alex.bennee@linaro.org >> Date: Wed, 20 Jul 2016 20:56:28 -0400 >> >> >> Maybe there's a misunderstanding. What Noam suggested was just to >> >> move the code which adjusts search_regs.start[i] and .end[i] to before >> >> the call to replace_range. >> > >> > Oh, right, that's also an option. It might suffer from another problem, >> > which is that the match-data will be broken while the >> > before-change-functions are run, so if there's a save-match-data there >> > we're back to square one. >> >> Solution: adjust in between the before and after change functions. >> Patch below. I think there shouldn't be performance problems, although >> it does add yet another flag to replace_range (by the way, I noticed >> that the MARKERS flags is never 0, so it's redundant). I tested with >> the attached bug-23917-match-data-buffer-modhook.el. > > Thanks. > > Please also make sure bug#23869 is still fixed after this. Following the recipe in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23869#11 gives me 'Lisp error: (error "Match data clobbered by buffer modification hooks")', that indicates it's still fixed, right?