unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Petton <nicolas@petton.fr>
To: "Simen Heggestøyl" <simenheg@gmail.com>,
	"Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: 24389@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#24389: [PATCH] Support completion of classes and IDs in CSS mode
Date: Sat, 24 Sep 2016 17:00:57 +0200	[thread overview]
Message-ID: <877fa1cpg6.fsf@petton.fr> (raw)
In-Reply-To: <1474096252.26266.1@smtp.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Simen Heggestøyl <simenheg@gmail.com> writes:


> OK, I changed it to use the buffer's tick counter instead. I also
> changed `seq-uniq' to `delete-dups', which resulted in a massive
> speedup. Some benchmarks using the same test files as before follow.
>
> * With `seq-uniq':
> (benchmark 10 '(css--foreign-completions 'css-class-list-function))
>     "Elapsed time: 4.198944s (0.911449s in 60 GCs)"
>
> * With `delete-dups':
> (benchmark 10 '(css--foreign-completions 'css-class-list-function))
>     "Elapsed time: 0.282890s (0.188205s in 10 GCs)"
>
> As a side note, maybe a hashing strategy like the one `delete-dups'
> uses would be good for `seq-uniq' too?

Yes, seq-uniq could be optimized.  I'll look into it.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

      parent reply	other threads:[~2016-09-24 15:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 17:40 bug#24389: [PATCH] Support completion of classes and IDs in CSS mode Simen Heggestøyl
2016-09-07 20:01 ` Stefan Monnier
2016-09-10 12:13   ` Simen Heggestøyl
2016-09-10 19:55     ` Stefan Monnier
2016-09-17  7:10       ` Simen Heggestøyl
2016-09-17 12:35         ` Stefan Monnier
2016-09-24 11:58           ` Simen Heggestøyl
2016-09-24 15:00         ` Nicolas Petton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fa1cpg6.fsf@petton.fr \
    --to=nicolas@petton.fr \
    --cc=24389@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=monnier@iro.umontreal.ca \
    --cc=simenheg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).