From: npostavs@users.sourceforge.net
To: Alex <agrambot@gmail.com>
Cc: Vincent Lefevre <vincent@vinc17.net>, 23007@debbugs.gnu.org
Subject: bug#23007: 24.5; buggy interactive search with middle click
Date: Tue, 30 May 2017 07:47:56 -0400 [thread overview]
Message-ID: <877f0y4lcj.fsf@users.sourceforge.net> (raw)
In-Reply-To: <8760gjqcwh.fsf@gmail.com> (Alex's message of "Mon, 29 May 2017 20:47:10 -0600")
Alex <agrambot@gmail.com> writes:
> npostavs@users.sourceforge.net writes:
>
>> Alex <agrambot@gmail.com> writes:
>>
>>> + (let ((overriding-terminal-local-map nil))
>>> + (setq binding (key-binding (this-command-keys-vector) t)))
>>
>> IMO, it would be better style to do something like
>>
>> (let ((binding (let ((overriding-terminal-local-map nil))
>> (key-binding (this-command-keys-vector) t))))
>> ...)
>
> That was my first idea, but at the time I thought it was better style to
> use the setq version instead. :)
Hah, well it is somewhat a question of personal opinion, but generally I
try to avoid setq, if it's not too much trouble.
> Your version makes the binding more obvious, though, so I updated the
> patch to use it. I've attached it below.
Ok, I'll push to master in a couple of days.
next prev parent reply other threads:[~2017-05-30 11:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 3:10 bug#23007: 24.5; buggy interactive search with middle click Vincent Lefevre
2017-05-29 19:56 ` Alex
2017-05-29 23:56 ` npostavs
2017-05-30 0:41 ` Drew Adams
2017-05-30 0:53 ` npostavs
2017-05-30 1:07 ` Drew Adams
2017-05-30 1:28 ` npostavs
2017-05-30 2:04 ` Drew Adams
2017-05-30 2:47 ` Alex
2017-05-30 4:44 ` Drew Adams
2017-05-30 11:47 ` npostavs [this message]
2017-06-01 22:09 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f0y4lcj.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=23007@debbugs.gnu.org \
--cc=agrambot@gmail.com \
--cc=vincent@vinc17.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).