From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24402: should-error doesn't catch all errors Date: Thu, 13 Jul 2017 19:49:26 -0400 Message-ID: <877ezbew3d.fsf@users.sourceforge.net> References: <3654D8E9-D3CB-402B-922F-B132C1871E9F@runbox.com> <596E65D2-E780-43A1-A75B-603B61B6F9F4@runbox.com> <87zickhoco.fsf_-_@lylat> <877eznda7v.fsf@lylat> <874lur0zki.fsf@calancha-pc> <87o9sywtbz.fsf@lylat> <87fue3f9p8.fsf@users.sourceforge.net> <87vamyl3j3.fsf@lylat> <87tw2het1b.fsf@users.sourceforge.net> <874luhbo4l.fsf@lylat> <87lgntdswo.fsf@users.sourceforge.net> <87k23d9gvt.fsf@lylat> <87d195dmr0.fsf@users.sourceforge.net> <87lgns7y7g.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499989758 20955 195.159.176.226 (13 Jul 2017 23:49:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Jul 2017 23:49:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Gemini Lasswell , 24402@debbugs.gnu.org, Tino Calancha To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 14 01:49:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVnr1-0004se-KD for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Jul 2017 01:49:07 +0200 Original-Received: from localhost ([::1]:34702 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVnr6-00051l-Nq for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Jul 2017 19:49:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVnqz-0004wG-GE for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2017 19:49:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVnqw-0001zb-Ek for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2017 19:49:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVnqw-0001zX-8u for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2017 19:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dVnqv-00007p-SV for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2017 19:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2017 23:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24402-submit@debbugs.gnu.org id=B24402.1499989683403 (code B ref 24402); Thu, 13 Jul 2017 23:49:01 +0000 Original-Received: (at 24402) by debbugs.gnu.org; 13 Jul 2017 23:48:03 +0000 Original-Received: from localhost ([127.0.0.1]:37524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVnpz-00006R-3A for submit@debbugs.gnu.org; Thu, 13 Jul 2017 19:48:03 -0400 Original-Received: from mail-it0-f52.google.com ([209.85.214.52]:36874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVnpx-00005v-Pj for 24402@debbugs.gnu.org; Thu, 13 Jul 2017 19:48:02 -0400 Original-Received: by mail-it0-f52.google.com with SMTP id m84so8849601ita.0 for <24402@debbugs.gnu.org>; Thu, 13 Jul 2017 16:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eYyocEUldQ5I8FbSc9ULQub03fdi85jiZ0kIPnqrXcs=; b=IS2/UjL+6tTq9aaPiKoxQIp48NryH7WNaF0YXSpJZrs6QWlgAOnDzPXmb9N7OiANNL DbT7rhU6AnZGbA9u6sra7+z33xurFAJV3z1hx6T+rwm5jfEsYlXt219XDp0YoWD5qYe9 yijnVpzWHHteed89e879Zzv20+C82d4g3IpmWPoz93exU+CGqSzIJ7Lc4sZgDAFEkcKX cY+PKpX96UNyveVYL6IdeBUCJKwRbA+DoiYKswZwGUMFFpFFg9AHz//vpFYUs6aSNBDQ 8yLpJvszTpD1D9rGYSkqyJeRZCoI7Xf8xK7DV0IpXU/hGXoHnffob7bRpNCwROMkRnq3 Lttg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=eYyocEUldQ5I8FbSc9ULQub03fdi85jiZ0kIPnqrXcs=; b=qR7fArGbc+YIF9CbCHjhfEldPtNTO86DppK98WuaWoJ3Rt8BTHqZR0PbhCyUaDeuoL Wz6ww0OgMg5yid2SyB6PcwdP1wEaR/KcIYb36Gd0gYSTfVJVHV3Q8DspyGVi1W0ivlEW Z3r+1+xKfnnedMDwMXD+NRmrX2FTHLngBxGxRKIZ2LprUaW2KTfh0S/rRGmQ2oEIvHt8 DNLvkoJBlLetXcKTKHNwNiq9VfozxiVRc5RAyAx1sBC46NND2HVrtpNOtA20rAb+vphh gXs0L7/G/q6VuQ/M+5QlbkCaxnOM/X5l5e4fm+71XHfzhmYqZ24TBa2CvkL5H8uTV8UP z6ZA== X-Gm-Message-State: AIVw112ZUmClL+aT2yGnswW4ElxB9GgQGggNXyVzcdk93sEmJIb2GmHp TPdR1/rdOJi2mg== X-Received: by 10.107.152.85 with SMTP id a82mr5947710ioe.105.1499989675083; Thu, 13 Jul 2017 16:47:55 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id s135sm1802298ita.2.2017.07.13.16.47.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Jul 2017 16:47:53 -0700 (PDT) In-Reply-To: <87lgns7y7g.fsf@lylat> (Alex's message of "Thu, 13 Jul 2017 16:45:39 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134523 Archived-At: Alex writes: > npostavs@users.sourceforge.net writes: >> It would be nice if we can make code inside tests behave the same as >> outside. But we should make it conditional on whether the code is being >> compiled, otherwise code inside tests would behave differently when >> being interpreted. Anyway, we can leave this for a separate bug. > > I agree, but that sounds like it'll require a fair bit of refactoring > and knowledge of ert internals. I don't think so, just a conditional to decide whether or not to call the extra expansion. Do you think there is anything else? > OOC, is there a robust way to check whether or not you're currently > byte-compiling? AFAIK, the usual trick is (bound-and-true-p byte-compile-current-file). It's probably good enough for most things. > I was going to ask if you would merge in a few days, but it appears that > what should have been a simple rebase to master caused unforeseen > consequences. For instance, for some reason I now get a segmentation > fault when executing 'make cl-lib-tests TEST_LOAD_EL=no'. I even reset > to the commit I was at before and it still segfaults. Can you reproduce > this with the following patch on master? Nope, I just get the failures on cl-lib-defstruct-record we already mentioned.