From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; " Date: Wed, 15 Aug 2018 20:02:01 -0400 Message-ID: <877ekrxjpi.fsf_-_@gmail.com> References: <13011331534241125@iva4-f774db2b5297.qloud-c.yandex.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534377669 18936 195.159.176.226 (16 Aug 2018 00:01:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Aug 2018 00:01:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 23294@debbugs.gnu.org, "Mohammed Sadik P. K." To: Wenjamin Petrenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 16 02:01:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq5ip-0004oA-Li for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Aug 2018 02:01:03 +0200 Original-Received: from localhost ([::1]:52753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fq5kw-0000tv-AN for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Aug 2018 20:03:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fq5kn-0000sy-Dg for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2018 20:03:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fq5kk-0007OY-4n for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2018 20:03:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47133) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fq5kj-0007OO-V6 for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2018 20:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fq5kj-0003Fg-Lv for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2018 20:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Aug 2018 00:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 23294-submit@debbugs.gnu.org id=B23294.153437773012436 (code B ref 23294); Thu, 16 Aug 2018 00:03:01 +0000 Original-Received: (at 23294) by debbugs.gnu.org; 16 Aug 2018 00:02:10 +0000 Original-Received: from localhost ([127.0.0.1]:52151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq5ju-0003ET-Cv for submit@debbugs.gnu.org; Wed, 15 Aug 2018 20:02:10 -0400 Original-Received: from mail-io0-f179.google.com ([209.85.223.179]:36145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq5js-0003E9-S1; Wed, 15 Aug 2018 20:02:09 -0400 Original-Received: by mail-io0-f179.google.com with SMTP id m4-v6so2468617iop.3; Wed, 15 Aug 2018 17:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3NM1RtvCgxa3wkOCaH9sw9J49S5Na+AAAL3fM/gUJ4o=; b=XnHZRZzzyI/ojiPxr0nKAP/Bl5VzZXnGhcKpwkGLDUc3e1UUQ+Q1nDdP5QDMvLYJTp Ab9T005LQP0nh31Vuses2dydgpB1THy/crf5uTL9yyu1yfm2+8oZmncyaGk5Iae6INDB +ScWCwlbmDgrVpS6zE7O6elWjQaDYWLdPGqhkBz4/B2mmACi9nn8aI2p4ecLCCpHI9zc F/YDtR18IDvt5eJoXTjjYXE8PNQUPjHn5p0CSvr4Zcpi4c07iWB8X3YY8Jpa2o/kSP4u pQ5+rfLkfOzX5UUGlLbFFQLUfhQY1RIFCsDU2GLPRZtWrT1f/SgNJf6L+am7/pfUfTdX 0c3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3NM1RtvCgxa3wkOCaH9sw9J49S5Na+AAAL3fM/gUJ4o=; b=eL4pw+mLNpFRKGCRLb+wfVzhjqcMvuLtGjWbnbBCXLGJ3QgnGR8Pi7wrCeSYRcaGMd FwGRhNIlxuVz6juBO2qf0oz8FFWKdn+gsHtAGUsOyMFC6lgjqIWCl2V+t6ZZcSmq6FoO 0bSKP3wMdfrxhehpxtwvOEzCu4DrHoBdX6Blt2tMcvp4CBzgwDWwx3JDohG9RTxy8JED Zp6B3tSsa2qbswojMciL8WHlY81v94mEw8z4yGOkDYk5j0Ak5o9hyx49BkRup1aoc+hY Lrat8OlF4fZUYdjEPdlbYybP1iCAFqMS0+E0x3TDAtLPFQ8zFCM5Bi3NrUajLpRNwK/c jFUw== X-Gm-Message-State: AOUpUlHpl+pkNlw47R7hA3eX5rHFnkD4cuvEzlUFc8mXFSy03P/styPC hA6P5Ges/cRLbK0wILMzoBUSxxRG X-Google-Smtp-Source: AA+uWPwcfylsG0PG5J0PCh0Avsxq7IjwIhtixqF5jRXh6zobEKezm9V6gyQx1Y8fvHDQ6v8+b1bO2Q== X-Received: by 2002:a6b:b657:: with SMTP id g84-v6mr23586975iof.210.1534377723222; Wed, 15 Aug 2018 17:02:03 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o18-v6sm8629879ioa.83.2018.08.15.17.02.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Aug 2018 17:02:02 -0700 (PDT) In-Reply-To: <13011331534241125@iva4-f774db2b5297.qloud-c.yandex.net> (Wenjamin Petrenko's message of "Tue, 14 Aug 2018 13:05:25 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149520 Archived-At: tags 23294 + patch quit Wenjamin Petrenko writes: > Subject: [PATCH] Fix bug#23294 > > * lisp/files-x.el (modify-file-local-variable-prop-line): Handle > whitespace when checking if there's a ';' before the variable name. > - (if (and (not (eq (char-before) ?\;)) > + (if (and (save-excursion > + (skip-chars-backward " \t") > + (not (eq (char-before) ?\;))) This looks reasonable. Could you give a more informative summary line please? I.e., one where I can see what the bug is about without having memorized all bug numbers. And same for your email subject headers, if you don't mind.