From: Noam Postavsky <npostavs@gmail.com>
To: Wenjamin Petrenko <wenjamin.petrenko@yandex.com>
Cc: 23294@debbugs.gnu.org, "Mohammed Sadik P. K." <sadiq@sadiqpk.org>
Subject: bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; "
Date: Wed, 15 Aug 2018 20:02:01 -0400 [thread overview]
Message-ID: <877ekrxjpi.fsf_-_@gmail.com> (raw)
In-Reply-To: <13011331534241125@iva4-f774db2b5297.qloud-c.yandex.net> (Wenjamin Petrenko's message of "Tue, 14 Aug 2018 13:05:25 +0300")
tags 23294 + patch
quit
Wenjamin Petrenko <wenjamin.petrenko@yandex.com> writes:
> Subject: [PATCH] Fix bug#23294
>
> * lisp/files-x.el (modify-file-local-variable-prop-line): Handle
> whitespace when checking if there's a ';' before the variable name.
> - (if (and (not (eq (char-before) ?\;))
> + (if (and (save-excursion
> + (skip-chars-backward " \t")
> + (not (eq (char-before) ?\;)))
This looks reasonable. Could you give a more informative summary line
please? I.e., one where I can see what the bug is about without having
memorized all bug numbers. And same for your email subject headers, if
you don't mind.
next prev parent reply other threads:[~2018-08-16 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 1:52 bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; " Mohammed Sadik P. K.
2016-04-15 7:55 ` Alexis
2018-06-05 23:51 ` Noam Postavsky
2018-08-14 10:05 ` bug#23294: Wenjamin Petrenko
2018-08-16 0:02 ` Noam Postavsky [this message]
2018-08-16 10:54 ` bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; " Wenjamin Petrenko
2018-08-25 1:59 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ekrxjpi.fsf_-_@gmail.com \
--to=npostavs@gmail.com \
--cc=23294@debbugs.gnu.org \
--cc=sadiq@sadiqpk.org \
--cc=wenjamin.petrenko@yandex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).