From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#33225: [debbugs.el] Don't send control message immediately Date: Sun, 31 Mar 2019 12:21:29 +0200 Message-ID: <877ecfqr86.fsf@gmx.de> References: <87k1lxhtfc.fsf@gmail.com> <87efc3lqwo.fsf@gmx.de> <87y34x84km.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="70601"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33225@debbugs.gnu.org, "garreau, alexandre" To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 31 12:22:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAXbP-000I7u-4s for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Mar 2019 12:22:11 +0200 Original-Received: from localhost ([127.0.0.1]:40047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAXbO-0001Au-3R for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Mar 2019 06:22:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAXbI-00018r-2U for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 06:22:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAXbG-00036Q-Uy for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 06:22:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAXbG-00036K-NV for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 06:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAXbG-00087T-Ew for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 06:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Mar 2019 10:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33225-submit@debbugs.gnu.org id=B33225.155402770331186 (code B ref 33225); Sun, 31 Mar 2019 10:22:02 +0000 Original-Received: (at 33225) by debbugs.gnu.org; 31 Mar 2019 10:21:43 +0000 Original-Received: from localhost ([127.0.0.1]:37810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAXaw-00086w-Rj for submit@debbugs.gnu.org; Sun, 31 Mar 2019 06:21:43 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:43383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAXau-00086g-MQ for 33225@debbugs.gnu.org; Sun, 31 Mar 2019 06:21:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1554027691; bh=jV4Jq3/JZ64fEJnWQPF2/3W1D+2Z8TECOxz7ZId6xBo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Jkdg85tb1+nY/aH8QEKFQ97vk4a2zIg3k7EU+31cZm8kML5XL5l1tHIU0hisGGe9l D5FPFj6a1Wk2NNUKpt8Kje9bCf/IwRo/M2mzUB3ZK+5RoLBG1jpNZ4idVNvX9SQRUI eBmgNqrhYrZNbBF6W40qLy1u1/uLutvfKgM1S5Vw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.46.233]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MLOMM-1hB5p32qkU-000cSS; Sun, 31 Mar 2019 12:21:31 +0200 In-Reply-To: <87y34x84km.fsf@gmail.com> (Noam Postavsky's message of "Fri, 29 Mar 2019 22:43:37 -0400") X-Provags-ID: V03:K1:hR8jNS00iymNxE286Vb/6G9HmruQAPWM3avkm3TC01eV9cmQD1L oH6bJJrq3byEjb57cHEtOMyjXOexpJ4f0m7AswNv7XCZS6Ko7/S3xkv2vCG9ei3SYjWEmSd BXWA7SfB4tFCqemCRaa68xATh6PU85yvPrxSPum3H2Bta7jM/F/UzIXMMeIccNxOMLSIGy3 fdK3AEg0kfk5xrQV5Pz5A== X-UI-Out-Filterresults: notjunk:1;V03:K0:Fn4mZ3gEjIA=:YDLI0YShijP3mJMAECr3XX 3XY2kXALJlW1NI+yvY11rXPnUw5NQQ384cHVHl6A6zaQ9pERMd4s5TXB016nEf0aPuxWW+H30 mT3OSp/LCcwNRROz6MmHnl5XnJEzwyI9Jp1amjSqlLwif4x9eZ2itAtGqknk7oZNMax2/jCvA v1NYQyCd+Ku+3u9rXbPzGrB9rqXlNYFWSIXUeBkG6mKSFvRR0OqSodppOVGCZav8NgZsqlwka VceMeQz5V8O0pijaCIAZ2TmHctBH4k4ZFX6ygd3y7HFSt+YurDkHi86tQj08C4z8px5lNAFj2 /QOpkvBa81F7xKs86U3jTMGNc9LVJYo8eOL5Qk5BL04gjc4XlSyLBC6ydvfgZOOqAaDaLYp3y 9y+QI7cWZNkYxa09qmzkRa/z/RXrkm+gnTpa912zc8KbzcSMHTX/CQCfSyqJ3RczfJ0U5WHdL OK6HQcBnVZV7DQZBg/8bLR7zvEDpgzaH996OfMLmDfuG064UJngenNOlGssEhI0JHolS3mjAA YUpt+1PrzBGnVW6kdzXULeJgbVZ4nVk3QdF3nJzOxJ/JXMu3eghyH9+XwoZJI/s09wkLJ+ccX uc7aHxhkRlCcBXM/6Tjw3mISX1EmvWfqy0VD13CwCW+qzXmDQFnRQZhPAjdYPyXGLAlVH0bwv tT3p/KPJnlJdH0m81QjGv4VtFyttAAMTIa4VPHr4Oc71tSqnhwsclP8WlYtJeLKEUQ6FjTR1d 3oiB82NaSiA7pp14O6DxGeEui+JSBBLDe9JZrgbc6KAez859Brhrm0lcLnKspeGcc1gGD4l0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156969 Archived-At: Noam Postavsky writes: Hi Noam, Thanks for the patch. In general, it works fine, so I guess you could push it. We (I)'ll play then for some days, and if there's no serious complaint, I'll make a new debbugs release. But I still have some comments :-) Please rename debbugs-control-make-message =E2=86=92 debbugs-gnu-make-control-message debbugs-control-message-keywords =E2=86=92 debbugs-gnu-control-message-keyw= ords debbugs-control-message-commands-regexp =E2=86=92 debbugs-gnu-control-messa= ge-commands-regexp debbugs-control-message-end-regexp =E2=86=92 debbugs-gnu-control-message-en= d-regexp Please add (the keybindings of) debbugs-gnu-make-control-message to the Commentary sections of debbugs-gnu.el and debbugs-org.el and to the nodes "Tabulated Lists" and "TODO Items" of debbugs-ug.texi. Compiling debbugs-gnu.el results in debbugs-gnu.el:1534:1:Warning: Unused lexical variable =E2=80=98addr=E2=80= =99 debbugs-gnu.el:1552:1:Warning: Unused lexical variable =E2=80=98micro=E2=80= =99 debbugs-gnu.el:1552:1:Warning: Unused lexical variable =E2=80=98subject=E2= =80=99 Maybe you can fix it? > Added, though it looks like the .info file is also in git? I haven't > regenerated it since I use texinfo 4.13, so that would trigger all sorts > of spurious changes. Yes, unfortunately, the info file must be there. Don't worry about, I'll regenerate. > +(defconst debbugs-control-message-keywords > + '("serious" "important" "normal" "minor" "wishlist" > + "done" "donenotabug" "donewontfix" "doneunreproducible" > + "invalid" ; done+notabug+wontfix > + "unarchive" "unmerge" "reopen" "close" > + "merge" "forcemerge" > + "block" "unblock" > + "owner" "noowner" > + "reassign" > + "retitle" > + "forwarded" "notforwarded" > + ;; 'notfixed ' works, even though it's > + ;; undocumented at debbugs.gnu.org. > + "fixed" "found" "notfound" "notfixed" > + "patch" "wontfix" "moreinfo" "unreproducible" "notabug" > + "pending" "help" "security" "confirmed" "easy" > + "usertag" "user" > + "documentation" ;; usertag:emacs.documentation > + )) I suppose "user" is needed in case of debbugs-gnu-make-control-message only. Could we separate this, and offer completion only for that function? > + ((member message '("merge" "forcemerge")) > + (format "%s %d %s\n" message bugid > + (read-string "Merge with bug #: "))) You have removed the bug number completion via debbugs-gnu-expand-bug-number-list. Why? > + ((member message '("block" "unblock")) > + (format > + "%s %d by %s\n" message bugid > + (mapconcat > + 'identity > + (completing-read-multiple > + (format "%s with bug(s) #: " (capitalize message)) > + (if (equal message "unblock") > + (mapcar 'number-to-string > + (cdr (assq 'blockedby status)))) > + nil (and (equal message "unblock") status)) > + " "))) dito > +@item user > +"user @var{username}" > + > +The username, read interactively, is either a package name or an email > +address. Please mention, that this is used in order to avoid giving the user name again, for further commands. Best regards, Michael.