From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Date: Thu, 11 Apr 2019 17:59:52 +0100 Message-ID: <877ec032bb.fsf@tcd.ie> References: <87d0ls32ke.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="85115"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eric Abrahamsen , Katsumi Yamaoka To: 35233@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 11 19:01:39 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEd4v-000LuQ-GC for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 19:01:34 +0200 Original-Received: from localhost ([127.0.0.1]:52251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEd4u-0004us-Cz for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 13:01:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEd4U-0004t9-13 for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 13:01:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEd4Q-00069C-OZ for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 13:01:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEd4Q-00068w-AF for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 13:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEd4P-0001Sg-Uy; Thu, 11 Apr 2019 13:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 Apr 2019 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35233 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 35233-submit@debbugs.gnu.org id=B35233.15550020115550 (code B ref 35233); Thu, 11 Apr 2019 17:01:01 +0000 Original-Received: (at 35233) by debbugs.gnu.org; 11 Apr 2019 17:00:11 +0000 Original-Received: from localhost ([127.0.0.1]:55121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEd3b-0001RN-9W for submit@debbugs.gnu.org; Thu, 11 Apr 2019 13:00:11 -0400 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:38527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEd3W-0001PG-Jb for 35233@debbugs.gnu.org; Thu, 11 Apr 2019 13:00:09 -0400 Original-Received: by mail-ed1-f51.google.com with SMTP id d13so5858063edr.5 for <35233@debbugs.gnu.org>; Thu, 11 Apr 2019 10:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dd3uhxdpPyuIS3o6dlWDrSirHFBbrbiHKvgbGRWnE4c=; b=vgifLwi539Vn7DVOLW+rGbFpTRXWle9imwb793eLst0YNNKT6BGz6ZxH0vTTqCfjZQ FMu9K6RYNkG1M6yF/qtAd00F+9fgTFQMybw4TLfW7gGzyfTogmqGWXbvIAMAJDw8B4J2 t72mzjnfFit+jo1CoXNh8uPqrec/ApIwQiAadB+P4PxqudGscO7XtEpkQDut1i1AsR+r ospGaMAeEej+9QupT6yd3uDmuEISrmz33rQ8BINIpNgTuQ6QNt4BTW0wevGXCOe1DKci qAdYKbwl34BCJVPN6nh9nagCMGKYct2BRMscy7pjRBrn3tHJDat1O1emo2dXxNNzqoS0 IYuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dd3uhxdpPyuIS3o6dlWDrSirHFBbrbiHKvgbGRWnE4c=; b=MlhKAWFCUQHR7gDvM6lOgyILNA2Pr3iMLXhcQDNsSKcP21WmxR/sfSHqNDDjRo4Pzt eCsH6TyUG6AAIDuyG7yF0nwEgeVDiCL3Cn3UYAx+EOsBFNHdatAVhFlaXkxgP2JMgPRg vNc27KsRCKt7OiKn08RZFwcj+890dFNZsjX5l6L4zgfLuIbXqr1TXLuxLTKNhHYSQhI4 qVhXKr2trOESgMyyi2ypra4sSkvyYIVisDEV7BgC+NZpB1UHqnxKZ8DWOuXDHM1r+cTB /O3032W88UhbwvYGpkoW7cCOvsYCEQzXPzJqmbco3lS3eKPpP5YQj28F8Z4JMosEGdC9 FnIA== X-Gm-Message-State: APjAAAXLKPuwDiElRn3di1Vs2R3iv0OW3gLoHpQMBPdcRUteIyRSwvzd D8BJCMDZ0wtuNp/cxpVJfjQtuZgUzGKPQ99y X-Google-Smtp-Source: APXvYqw8LExEouR0PXAIdAXkmGUt7Skt+l+QMUxj4jblElxAm7pIuymMRe1kb5vq9lSH5nV/7XDvNA== X-Received: by 2002:aa7:d6cb:: with SMTP id x11mr30989297edr.85.1555002000624; Thu, 11 Apr 2019 10:00:00 -0700 (PDT) Original-Received: from localhost ([163.172.211.46]) by smtp.gmail.com with ESMTPSA id 63sm1102742edn.32.2019.04.11.09.59.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Apr 2019 09:59:59 -0700 (PDT) In-Reply-To: <87d0ls32ke.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 11 Apr 2019 17:54:25 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157511 Archived-At: --=-=-= Content-Type: text/plain tags 35233 patch quit --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-gnus-group-describe-all-groups-bug-35233.patch >From 6402b26d5fb0340b90cd5647a6799fff2cb35e43 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Thu, 11 Apr 2019 17:16:00 +0100 Subject: [PATCH] Fix gnus-group-describe-all-groups (bug#35233) This fixes oversights from 2018-04-26T16:26:27-07:00!eric@ericabrahamsen.net and 2016-02-13T18:45:11+11:00!larsi@gnus.org. * lisp/gnus/gnus-group.el (gnus-group-describe-all-groups): Insert group name and description instead of group name twice. Do not pass a hash-table to intern. Call sort with correct number of arguments. --- lisp/gnus/gnus-group.el | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index 144496bdd2..e1554cab8a 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -4149,20 +4149,19 @@ gnus-group-describe-all-groups (when (not (or gnus-description-hashtb (gnus-read-all-descriptions-files))) (error "Couldn't request descriptions file")) - (let ((buffer-read-only nil) - (groups (sort (hash-table-keys gnus-description-hashtb))) - b) + (let ((buffer-read-only nil)) (erase-buffer) - (dolist (group groups) - (setq b (point)) - (let ((charset (gnus-group-name-charset nil group))) + (dolist (group (sort (hash-table-keys gnus-description-hashtb) #'string<)) + (let ((b (point)) + (desc (gethash group gnus-description-hashtb)) + (charset (gnus-group-name-charset nil group))) (insert (format " *: %-20s %s\n" (gnus-group-name-decode group charset) - (gnus-group-name-decode group charset)))) - (add-text-properties - b (1+ b) (list 'gnus-group (intern group gnus-description-hashtb) - 'gnus-unread t 'gnus-marked nil - 'gnus-level (1+ gnus-level-subscribed)))) + (gnus-group-name-decode desc charset))) + (add-text-properties + b (1+ b) (list 'gnus-group group + 'gnus-unread t 'gnus-marked nil + 'gnus-level (1+ gnus-level-subscribed))))) (goto-char (point-min)) (gnus-group-position-point))) -- 2.20.1 --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > Patch fixing these to follow. I attach said patch. Thanks, -- Basil --=-=-=--