From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35362: 26.2; [debbugs.el] Automate commit -> debbugs flow (posting patches, closing bugs after pushing) Date: Sat, 27 Apr 2019 09:44:24 -0400 Message-ID: <877ebfr29z.fsf@gmail.com> References: <874l6rtnjo.fsf@gmail.com> <871s1vtm9h.fsf@gmail.com> <87wojns7ia.fsf@gmail.com> <875zr7cepw.fsf@gmx.de> <87d0ldsu6w.fsf@gmail.com> <87tvep87xg.fsf@gmx.de> <87pnparg0j.fsf@gmail.com> <87lfzy8ela.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="43617"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35362@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 27 15:45:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKNdh-000BCS-8f for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Apr 2019 15:45:13 +0200 Original-Received: from localhost ([127.0.0.1]:60569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKNdg-0000kQ-1x for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Apr 2019 09:45:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKNdY-0000kF-E7 for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 09:45:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKNdX-0001wl-11 for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 09:45:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49470) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKNdW-0001wF-PV for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 09:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hKNdW-0000rz-HY for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 09:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 13:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35362-submit@debbugs.gnu.org id=B35362.15563726763289 (code B ref 35362); Sat, 27 Apr 2019 13:45:02 +0000 Original-Received: (at 35362) by debbugs.gnu.org; 27 Apr 2019 13:44:36 +0000 Original-Received: from localhost ([127.0.0.1]:34781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKNd5-0000qu-S4 for submit@debbugs.gnu.org; Sat, 27 Apr 2019 09:44:36 -0400 Original-Received: from mail-qt1-f175.google.com ([209.85.160.175]:36401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKNd3-0000qY-BP; Sat, 27 Apr 2019 09:44:34 -0400 Original-Received: by mail-qt1-f175.google.com with SMTP id c35so7319624qtk.3; Sat, 27 Apr 2019 06:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bxwueOgXY+p0toYpqm5tFjfih7ufyn+eWlII1bYV/ZQ=; b=PwqcExj/JaWs5Z3SQy/V6fsVWaGtuHflWL7G1DZTAd2N/UPJGnDbWDHALWOm3atAqd 7MetjX0ba1q/R0hvcPu1iRvVxtNbSfIKB9UH1/Onc4d44WTNVOtrK89UPXWM+VFQM++8 kNdZ6sUs4/FvhazHk7MytJEbql0z6KsBsAqJ+YrVc2ooK082lslIoZpQqnqsO43SvAln 8esJ6+zZKDjCbW2G3N8bt1t8zS27xle0EhSOfQUPDXUhZjJPzwRi3JBQ3R24K0mlDG5R gkVNBSxWFI7fw+7PgiRyGLeYowy6IgIeQsvlMmk38s5jJ8mC4zL6KRVErg4SG5KiGq6r 22LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bxwueOgXY+p0toYpqm5tFjfih7ufyn+eWlII1bYV/ZQ=; b=MU2bdJmN1th9G+e3b1CkvP5UetgjmrYdhohF17+9dsiC1N4zAQTUGNvtHr2dassGaq 854dZPhrv5HoOw0Ctq1QpsK5MPimn/tAUFOBtbIhuySgfywbV0G2Fmq5t52uJf1hYd02 aiMSM4hJK9/br1LLICzEAQ2XJ8m6l3p8E2mjyntAlWTYZ7ljmIHOZXhF+oRhOURbgBFb oNznrIRn3ivTS1FVCAmmH1buTiFIsYe2qxin/pH2iDEcX4J/3hxlj6n9Ozm2x8kRZI2v rl+3LdsXaB5DTc65RvrPg6xlGBSvvtYOMp2sSKzDQfRyxms1ySxU944rHnH67b9PZzf3 4hYw== X-Gm-Message-State: APjAAAWB84rx4l6OCZ8chixZZBmkY5f6pCZm2THiNEy/lWnx9JMAK9Ol nOrj1mVASpbmTwdAo2zO/6Kal0kC X-Google-Smtp-Source: APXvYqyjIXw/uN7zZl4d7xHNPHlemGjy7oxwW8LT5LsClHa1swqOcASn4esfvavmCViP+vQ3sHdOZg== X-Received: by 2002:ac8:1417:: with SMTP id k23mr40760753qtj.288.1556372667443; Sat, 27 Apr 2019 06:44:27 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n66sm10781873qkf.49.2019.04.27.06.44.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Apr 2019 06:44:25 -0700 (PDT) In-Reply-To: <87lfzy8ela.fsf@gmx.de> (Michael Albinus's message of "Thu, 25 Apr 2019 14:16:33 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158348 Archived-At: tags 35362 fixed close 35362 quit Michael Albinus writes: > I believe your patch is almost OK, so let's apply it. But of course, I > still have some few remarks :-) Okay, pushed to master. 35f0db153 2019-04-27T09:28:21-04:00 "Automate commit -> debbugs workflow (Bug#35362)" https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?id=35f0db1532612e8b6b4bcc5ecd2f7e479735110a >>>> Invoke the command @code{debbugs-gnu-pick-commits} and press >>> >>> Should we give this command a key binding? >> >> Maybe, but then the question is what map to bind it in. Is it okay to >> start adding things into vc-git-log-view-mode-map? > > Yep. Maybe we bind "c" for it, because other candidates (d/D/p/P) seem > to be bound already. Actually I noticed there are some minor modes that exist just to bind some dwim command in a few different modes, so I added a debbugs-gnu-pick-vc-log-commit-mode with the "c" binding (otherwise we would need eval-after-load to change vc-git-log-view-mode-map which package code isn't supposed to use). > Furthermore, we might mention debbugs-gnu-pick-commits in the > ;;; Commentary section of debbugs-gnu.el. > > >> --- a/packages/debbugs/debbugs-gnu.el >> +++ b/packages/debbugs/debbugs-gnu.el > >> + (add-hook 'message-send-actions >> + (lambda () (remhash bugid debbugs-cache-data)) >> + nil t))) > > Do we need to declare message-send-actions? No, add-hook operates on a symbol, not a variable. >> +(defun debbugs-gnus-jump-to-bug (bugid) >> + "Display buffer associated with BUGID with `pop-to-buffer'. >> +Use `gnus-read-ephemeral-emacs-bug-group' instead if there is no such buffer." > > Maybe you could add at least a FIXME for the lack of rmail support. Ok. Actually I see there is a debbugs-read-emacs-bug-with-rmail function, so I think it shouldn't be too hard to figure out rmail support, but I'll do it in a separate patch. >> +(defun debbugs-gnu--git-insert (&rest args) >> + "Insert output of running git with ARGS. >> +Throws error if git returns non-zero. Uses `vc-git-program'." > > Don't mention vc-git-program. ok >> + (unless (eql 0 (apply #'vc-git--call '(t t) args)) > > Declare vc-git--call. right. >> +(defun debbugs-gnu--git-remote-info () >> + "Return (REMOTE . INFO-ALIST)." > > Say, that REMOTE is a string, which must be matched by REMOTE-REGEXP of > debbugs-gnu-git-remote-info-alist. Refer to the docstring of that user option. right >> + (dir (make-temp-file (format "patches-for-bug%d-" bugnum) t)) > > I'm curious: Why a trailing "-" in the buffer name? That was a typo. >> + (deldir (lambda () >> + (delete-directory dir t) >> + (remove-hook 'message-exit-actions deldir t) > > Do we need to declare message-exit-actions? no (as for add-hook) >> + (dolist (patch (directory-files dir t "\\`[^.]")) >> + (mml-attach-file patch type "patch" disposition)) > > Do we need to declare mml-attach-file? It seems to already be autoloaded. >> +`debbugs-gnu-pick-commits' and jump to read bug in prepration for > > Typo. oops. >> --- a/packages/debbugs/debbugs-ug.texi >> +++ b/packages/debbugs/debbugs-ug.texi > >> +The string inserted to describe an announced commit is controlled by >> +the variable @code{debbugs-gnu-commit-description-format}, it is a > > It is a user option. > >> +subitem is appended to the commit description. By default this >> +variable is configured for the GNU Emacs and GNU ELPA repositories, > > That's also a user option. Right, I don't use customize much, so the distinction is lost on me.