From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#35564: 27.0.50; [PATCH] Tweak dired-do-shell-command warning about "wildcard" characters Date: Wed, 08 May 2019 22:42:45 +0200 Message-ID: <877eb0ptiy.fsf@gmail.com> References: <87zho2cd4f.fsf@gmail.com> <071cc96c-1bf2-f331-8f9e-b3c54a7452da@gmx.at> <877eb3e5im.fsf@gmail.com> <9bd289fe-3623-4c45-4c4f-04c6668cae76@gmx.at> <9fc1129c-5377-4b56-ba6d-dce497140941@default> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="155166"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35564@debbugs.gnu.org To: Drew Adams , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 08 22:43:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOTPJ-000e79-3l for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 22:43:17 +0200 Original-Received: from localhost ([127.0.0.1]:43593 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOTPI-0004Bs-2U for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 16:43:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOTP5-0004AL-Nx for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 16:43:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOTP4-0001EN-Lx for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 16:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOTP4-0001EE-HS for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 16:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOTP4-0005vh-Ak for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 16:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.155734817622779 (code B ref 35564); Wed, 08 May 2019 20:43:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 8 May 2019 20:42:56 +0000 Original-Received: from localhost ([127.0.0.1]:34162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOTOx-0005vL-OS for submit@debbugs.gnu.org; Wed, 08 May 2019 16:42:56 -0400 Original-Received: from mail-wm1-f67.google.com ([209.85.128.67]:35647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOTOw-0005v2-3d for 35564@debbugs.gnu.org; Wed, 08 May 2019 16:42:54 -0400 Original-Received: by mail-wm1-f67.google.com with SMTP id y197so296313wmd.0 for <35564@debbugs.gnu.org>; Wed, 08 May 2019 13:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=9ijUDtjRfu2Yz9a0aK2g3lpaL/qyd6gwMqzMGGOE0L4=; b=qevMt2yx8Pj+MZbp6Zh5d173LXkC0j2PoK1pFTgD/PsJptoELmAPjWL4CQVPoLHPin DUHMnmQ36JAuym9n4I9WXtvpqaX3cV/ztDQLA3rFNUb2R6xWhqA/XMPkZNymU0d4lOUt 0n87ek75Xl6gSzNRF3AFCGIyxcN85NY/KNbyqF1YloRnq+FkuwSGUhwlmVRWHwmVMAXR MsOSEEdDmNeG2p0ZBvPUr5ZtYbQR7YaM5wdHPDxdIIdUqQfMdNVVViqNEoHT5gZRJPG1 oMXdVY5X6sgatuN9AWeCxl1GtIPhGFYD4sV+gdn0jEnchwGMp4X1I993bb0P4JrC03bm d+wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=9ijUDtjRfu2Yz9a0aK2g3lpaL/qyd6gwMqzMGGOE0L4=; b=ndGjCPO041Zq/FwpjPkEqA7RO2CsS5XJJXUtSAFtAagksYgDujusW7gU1YsNyUNvlj b0DN6DTfdAlpAMTeHQHROT+9r+br/eFljKoRGah+1sru3DJTBSA2wYJrMLzcST5Od3vQ 2ne2bwsQksqz/l7+C5rwZvOeMa5C9PW9ScX049OvHkFIpe7o5kCylMVe9bnzhz9xVqK8 fu7yLKgGWLolpNBRLGbDEgUTcC4OfrLk3vmHkrzm+aT386MGLn6NhNwF75IEhszmV/jS zlLOyx60nlcTAA8uJ7diO6isVeOKq92q3w2BiQZkdOYVMLVUu1ddmQW3qUefHgINFvM5 WHfQ== X-Gm-Message-State: APjAAAXjSwWCwE8ZVmCIdUIsEkiw1bMQKjmZr0gauRc527QfAI09eem3 fFAM24enEitEImquLRWqkE9qVdhT X-Google-Smtp-Source: APXvYqyue9f+FSjCqB+0NE75t2G97CraoY00smwApaOCk9MIa0F3gYec1uCQ/fmMu7SAB6+/DKkTxA== X-Received: by 2002:a7b:ce06:: with SMTP id m6mr146613wmc.62.1557348167981; Wed, 08 May 2019 13:42:47 -0700 (PDT) Original-Received: from my-little-tumbleweed (71.142.13.109.rev.sfr.net. [109.13.142.71]) by smtp.gmail.com with ESMTPSA id s3sm35692567wre.97.2019.05.08.13.42.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 13:42:46 -0700 (PDT) In-Reply-To: <9fc1129c-5377-4b56-ba6d-dce497140941@default> (Drew Adams's message of "Tue, 7 May 2019 06:19:10 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158961 Archived-At: Drew Adams writes: > I don't see any good reason why face `minibuffer-prompt' > should be used, especially by default (users can do > whatever they like) for situations where there is no > active minibuffer, i.e., for prompting situations > generally. It should instead serve as a useful clue > that the minibuffer is being used. (Just one opinion.) I'd hazard a guess[1] that this was done to make y-or-n-p and yes-or-no-p similar from a UI point of view: they both prompt the user for a binary answer, therefore the prompt might as well look the same in both situations. >From what I can tell the use of 'minibuffer-prompt' in minibuffer-less situations has enough precedents (the "other clients" Martin mentions) that the "minibuffer-" prefix might be considered a historical accident by now=E2=80=A6 (Perhaps those clients could be migrated to a new face, e.g. 'message-prompt', which would inherit 'minibuffer-prompt' by default?) martin rudalics writes: > So although I'd vote for a solution like the one you propose in your > patch, any decision in this area is subtle and should be approved by > others first. Also because we'd then have to decide what to do with > other clients of the 'minibuffer-prompt' face like 'read-char-choice' > or the ones in isearch.el. Fair enough. Should I raise the issue on emacs-devel, or create a new bug report? Just to make sure I am not omitting something, is this how you would sum up the issue? - In the context of bug#35564, I would like to add text properties to the y-or-n-p prompt (although I'm open to other, simpler solutions e.g. simply changing Dired's message). - While this can be patched within y-or-n-p and we can call it a day, the minibuffer-prompt-face-adding code could be factored out of 'read_minibuf'. - This raises two questions: 1. Do we actually want to use the 'minibuffer-prompt' face in this context, since the minibuffer is not involved? =20=20=20=20=20=20=20 2. What do we do with other clients of 'minibuffer-prompt', which use the same (propertize prompt 'face 'minibuffer-prompt) idiom? Thank you both for your thoughts on this. [1] AFAICT, the commit that added this face (927be33, back when y-or-n-p was still a C function) does not say why this was thought to be a good idea.