From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#30626: 26.0.91; Crash when traversing a `stream-of-directory-files' Date: Fri, 10 May 2019 15:20:08 +0200 Message-ID: <877eay30qf.fsf@web.de> References: <87inaiss6l.fsf@web.de> <6FCF6ACA-4F29-4B6B-BE9D-D7130C6E9495@gnu.org> <87fu5moe4c.fsf@web.de> <877eqyocro.fsf@web.de> <83zi3uz4nb.fsf@gnu.org> <87lgfd52by.fsf@gmail.com> <87bmg91ity.fsf@web.de> <87imv2rcs3.fsf@gmail.com> <87y33ybr1a.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="73290"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Nicolas Petton , 30626@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 10 15:21:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hP5Sc-000ImY-K9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2019 15:21:14 +0200 Original-Received: from localhost ([127.0.0.1]:43247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP5Sb-0007Zv-JR for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2019 09:21:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP5SR-0007ZW-JR for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 09:21:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hP5SQ-0003ZD-Ms for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 09:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52142) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hP5SQ-0003Yp-9S for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 09:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hP5SQ-0007zh-2F for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2019 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30626 X-GNU-PR-Package: emacs Original-Received: via spool by 30626-submit@debbugs.gnu.org id=B30626.155749442330672 (code B ref 30626); Fri, 10 May 2019 13:21:02 +0000 Original-Received: (at 30626) by debbugs.gnu.org; 10 May 2019 13:20:23 +0000 Original-Received: from localhost ([127.0.0.1]:37453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP5Rn-0007ye-9I for submit@debbugs.gnu.org; Fri, 10 May 2019 09:20:23 -0400 Original-Received: from mout.web.de ([212.227.17.12]:45395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP5Rl-0007yR-ML for 30626@debbugs.gnu.org; Fri, 10 May 2019 09:20:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1557494409; bh=K4D9Gh2feNYNupGhQ1p9r1/L5cE5Rn0kit0R3ctaIzw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=j+njh/dB4cGNTUKCINU964/AcaKEs/eWs6LqjH6F+/juGzgVRgI3qpVkX8KTJLPJA 70Vdi4FTJ5yS2pwc1dLvA9tyTO/0ao/yJpzco7OiyX/16Y8GicWaZNaSMQ345r03LZ rh00MtKmHfMgHucVeWe4vFf4kZ+Z7zLnLoBTrXOc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([88.66.186.107]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MNtLj-1hN8RG0j1f-007W0w; Fri, 10 May 2019 15:20:09 +0200 In-Reply-To: <87y33ybr1a.fsf@web.de> (Michael Heerdegen's message of "Thu, 25 Apr 2019 07:19:29 +0200") X-Provags-ID: V03:K1:Dsr2GPXDjBABRy9lJnQAJrawe0ppzpo9pyTzq5jvPKG9WxvPr9F OScyGbLxfwxtgfLRW1LRbaYdeInvC5B+wlyok7htPfWeHhZ/U6HeqDoYQlLcjjwEVmDpEa1 0rORTezudomEJYlblJW1SvPixpbp1Gq8G2lYb/0UxTYRp7OfqP5hegONRMhRQNQAdwmamou 7MRh50si+7cQ+BJ7ssmzg== X-UI-Out-Filterresults: notjunk:1;V03:K0:7ATEk20CoZo=:8+ncqBShXBxUz2CqD2nY0y FxJS+BQhxhH+V+Q9kCJFytRpnkzu2H40fiQc/FbYkCbF0D3DuzVA2CHQrailChTWzuwbAak1R vU1sS9V9vmmqGwPDl2dawUzJodF+EoWE/thAnIu+If216HjTx2uAJTuMr6hyZNqy0jtwKZnjn +ZRMS8KpSP/B/hdd5pjbD81PVUCTde9rvRSIFkzFCK86yJ9PEFmq5UptINEkF0uEx9Dws8m7J smfMqf9C8wMJfPprx7b2yI0R1AMjxKwZnKlISYzog5H/g8QAgF2FN4fd+zvAZnPPu8k8RStig vjRxX7+ofOx1nnpoAYxosEzFJ1lk9riHWSUP5FiCbeUna5n1xfgoP6TCcTuqRAn7DRBFoo4N4 YCdr37xlU8y7H9cVTmSoyRmmicczeVviieoINisVaRLia85y4XP3nqOG9slKIVw4H2NxcU/I3 8c0qqNrrejYy/DJqrxSv4fvFYsJz6oTqqTOeMKoXT42qHWOXnap/0pM4rmMhHxjbyHTgMF2li 1uLbqCByt6HnXLhXHekzZ4Z2af1B8tJx8DXXwSZt0jQq7MPKPGo3S5L1JyPGnLCxXbp5AdoJY +zzJ8rL575iWhtTicVUhuSJUVBZPZQVQlRWhbNIzzdOZ5QTlMn1Ko+RZBFICvbC+Cgg5KsVCM 6A8acS/ionhq62H3tRayN+w4/fYBAqoQBHXMpGxKaXYPEyI4Vg/0SyRG/Kay0anv47gGat+XK itH/L5EEYYwGX3ttWAZV6uFWGmwMcHUicVd+AfniW7UUs6hBH4udAn5JF0MSekhTRZqfBS0n X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159041 Archived-At: Michael Heerdegen writes: > > [Patch...] > > Works for me, and it makes sense. As a test case I recompiled > el-search.el (it uses streams for several things) with your patch > applied to stream.el, and it worked well. @Nicolas: If you are short on time, can we just install this patch? I've tested it for a while and it works well, and I'm quite sure it is harmless (doesn't change any semantics apart from fixing the crashes). > > - stream-make should use cons instead of list (or maybe a struct?). > > I think cons would be ok. Would a struct make things slower? > > > - stream-empty should just be a constant. > > Dunno if there are cases where this would be problematic, but I guess we > could do this as well. @Nicolas: Do you want us to care about this or do you want to have a look yourself? I don't want to hurry, I just don't want this to be forgotten. If you say you have time in four months, it's still ok. Thanks, Michael.