From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object. Date: Thu, 30 May 2019 18:50:34 -0400 Message-ID: <877ea77e11.fsf@gmail.com> References: <87y3nga0lv.fsf@killashandra.ballybran.fr> <87h8t69d7b.fsf@ericabrahamsen.net> <87609lcbip.fsf@ericabrahamsen.net> <87bmjcc2rh.fsf@ericabrahamsen.net> <874lp4aije.fsf@ericabrahamsen.net> <83po7pwlgs.fsf@gnu.org> <87lgib4z2o.fsf@ericabrahamsen.net> <87wp1rcz21.fsf@users.sourceforge.net> <87mv2jkaap.fsf@killashandra.ballybran.fr> <87wp1nsk52.fsf@killashandra.ballybran.fr> <87y3m2jl3b.fsf@ericabrahamsen.net> <871shf30fn.fsf@killashandra.ballybran.fr> <87woz2qdyo.fsf@ericabrahamsen.net> <877er23rev.fsf@killashandra.ballybran.fr> <87sh9qufb2.fsf@ericabrahamsen.net> <87muzx52l7.fsf@killashandra.ballybran.fr> <87h8q4uc8x.fsf@ericabrahamsen.net> <87v9xv79nf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="56340"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: jwiegley@gmail.com, 29220@debbugs.gnu.org, monnier@iro.umontreal.ca, Pierre =?UTF-8?Q?T=C3=A9choueyres?= To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 31 00:51:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWTt8-000ETx-Vi for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 May 2019 00:51:11 +0200 Original-Received: from localhost ([127.0.0.1]:60040 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWTt8-0007mE-1E for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 18:51:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWTt1-0007km-EY for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 18:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWTt0-0004cW-Bc for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 18:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48982) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWTt0-0004cN-7i for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 18:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWTt0-0006Ue-4K for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 18:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2019 22:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29220 X-GNU-PR-Package: emacs Original-Received: via spool by 29220-submit@debbugs.gnu.org id=B29220.155925664524926 (code B ref 29220); Thu, 30 May 2019 22:51:02 +0000 Original-Received: (at 29220) by debbugs.gnu.org; 30 May 2019 22:50:45 +0000 Original-Received: from localhost ([127.0.0.1]:34292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWTsi-0006Tx-Sc for submit@debbugs.gnu.org; Thu, 30 May 2019 18:50:45 -0400 Original-Received: from mail-io1-f41.google.com ([209.85.166.41]:42072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWTsg-0006Tk-Pr for 29220@debbugs.gnu.org; Thu, 30 May 2019 18:50:43 -0400 Original-Received: by mail-io1-f41.google.com with SMTP id g16so6551678iom.9 for <29220@debbugs.gnu.org>; Thu, 30 May 2019 15:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=17/X34QGEDYKoYG6EUXhOQezIOvoTMh1NJEMB4KTxWk=; b=E7L7sXO0kdxjLZTx4bANS9SjGbLrW5uQLJmRvdLENjeWQhRZCcNuHBCgz8YYTCN9qZ 7haqQanhX97+I+FHmoLXq8jIM0oevx15JZ4ilqck6/JSHfxVd/xKemsAmMC6TvCxEW8m e7yi0rLA6FlLnW6cdOrFJaH9jdgTsW35x/jtXVzPdqJA6p50HLttoSx9eTf3Ul70uwGL DnJc+SoKrRVvYoh7nzUdh56YnXQRuh4zmRipzQr8/yTCHpKGRK2wRxzx2hFN2sZZocpY 7ghvGgUxYgtlJsdT9EwmYTzrhgN89WVJ9G9l4ZDlIevFT+lonDi2SER9YAVKAIeEV6bS hx0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=17/X34QGEDYKoYG6EUXhOQezIOvoTMh1NJEMB4KTxWk=; b=jK2FVO9jucsibIYUVQB3VW241nokxFQies1Lwa7aI/pmuqMXxv/EJAzdbbabON/VX2 6CTPAf/3Sw3vJPpVG+axX/h7sX2lOqSc48mLW/ud102+xi9sTi7lENluDMIXoZVTCMwl cI1AaE0+Bt/BKvF3+g6rzYZvA0cPuTk4Dstxp1LFMBW3aEyNguUdkCJsDIKi/8KWz/BL rxF+SbObmdA7aujpO0JdWtA/ldqYaSuaS/7K70rwQgYDyK//ZRdFu8I744l1PH7eVW6f ILQnoVkLzpl7lSwrsir/y261KOxEsRBVBSn3Nn48ML/DxbFCQj0BSut2m8pmvNNiGo4N 2PjA== X-Gm-Message-State: APjAAAV2u+o9B7RDSztnMni7Fg652XEZMhqtU6m4ht6SCxbgJ/Og4OTO 48buFH4BteO2uNFHsDkRmcY= X-Google-Smtp-Source: APXvYqwnyidsRIu3LzgxvkFn3Ji8H4jhi08F/+QD4aVdlqDb27IDIkqMGYPboS+5AxR2c8Rm3OXDYg== X-Received: by 2002:a5d:9f46:: with SMTP id u6mr4323941iot.297.1559256636944; Thu, 30 May 2019 15:50:36 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id s2sm1405084ioj.8.2019.05.30.15.50.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 May 2019 15:50:35 -0700 (PDT) In-Reply-To: <87v9xv79nf.fsf@gmail.com> (Noam Postavsky's message of "Mon, 27 May 2019 19:36:04 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159952 Archived-At: > Subject: [PATCH] Use plain symbols for eieio type descriptors (Bug#29220) > > Since Emacs 26, eieio objects use a class record (with circular > references) as the type descriptor of the object record. This causes > problems when reading back an object from a string, because the class > record is not `eq' to the canonical one (which means that read objects > don't satisfy the foo-p predicate). > * lisp/emacs-lisp/eieio.el (make-instance): As a (partial) fix, set > the record's type descriptor to a plain symbol for the type descriptor > when eieio-backward-compatibility is non-nil (the default). > * lisp/emacs-lisp/eieio-core.el (eieio--object-class): Call > eieio--class-object on the type tag when eieio-backward-compatibility > is non-nil. > (eieio-object-p): Use eieio--object-class instead of > eieio--object-class-tag. Pushed to emacs-26 (with the tests expanded to show expected fail with eieio-backward-compatibility set to nil). I'm leaving the bug open since this still fails with eieio-backward-compatibility=nil. 5f01af6c8e 2019-05-30T18:46:07-04:00 "Use plain symbols for eieio type descriptors (Bug#29220)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5f01af6c8e0f7355f7a99a80ff32369071f65eda