From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v2] Tweak dired warning about "wildcard" characters Date: Tue, 18 Jun 2019 10:52:58 +0200 Message-ID: <877e9jp95h.fsf@gmail.com> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87muinyoup.fsf@gmail.com> <87tvcum2h6.fsf@gmail.com> <85r27x2zrf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="216175"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35564@debbugs.gnu.org, Stefan Monnier To: npostavs@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 18 10:54:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hd9sp-000ttl-Ci for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jun 2019 10:54:27 +0200 Original-Received: from localhost ([::1]:54902 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hd9so-0000af-DE for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jun 2019 04:54:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45487) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hd9sR-0000Z3-QN for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 04:54:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hd9sQ-0001vm-Op for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 04:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58430) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hd9sQ-0001uj-Fk for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 04:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hd9sQ-00037v-BD for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 04:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jun 2019 08:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.156084798911941 (code B ref 35564); Tue, 18 Jun 2019 08:54:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 18 Jun 2019 08:53:09 +0000 Original-Received: from localhost ([127.0.0.1]:43741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hd9rZ-00036X-J2 for submit@debbugs.gnu.org; Tue, 18 Jun 2019 04:53:09 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:51731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hd9rX-000369-Jb for 35564@debbugs.gnu.org; Tue, 18 Jun 2019 04:53:08 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id 207so2280911wma.1 for <35564@debbugs.gnu.org>; Tue, 18 Jun 2019 01:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=FKGQhl+yQ10JJFBKqo1jqF5Sf6QS2DVtkgA8JzXhRis=; b=YewHB5Ir7ZzU7PPFSzq1kTI+jQQ6JHVbmXHEmeENBkz9FcNHUFn2k7VFA4jFoL7IaY uNRA87Hhuupbfe5VrXKqck/6wg4gYD1YXGrjtQGZ5mA3tO5XXkUIBL6LrnRH0sxxzADe emWFrCKMvJAsiPabfvDdJjqUy2AWq7OcU5EbpyuqIH+PrdLGS4/SVoQAn/IOz9giVRu3 6HGwBH9LXc6wyGrWzIBddPfBINO2U0CuEU5ocxYWULACqBBqLlNX5d5rKWvXqs3fAFyz qTfjOabHdmVWjhCa/B5Vu77g9OwOJdMM+VuA1O9vox7EZNY/IkUlYmkH8Do8McD94I+q rtww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=FKGQhl+yQ10JJFBKqo1jqF5Sf6QS2DVtkgA8JzXhRis=; b=ByE39FJ1j8nbv8jkcgPkq0oQYKYWnhoBFXmZe1F5qpDxkoUy/TG0eEQzhSGl9Fg7+K XRpSH8KDWfrGl3tv0QeSDsK/SemT3IcnuFZJMnYEJLHBpfaBlHNHaOsG0xCnoG4Mmb2C 1EM1PJh4eHGSInwsTpL2QTb67xCeVmc3q6If8a1VUPNNEbawZ0MW/a7x6yRIKR6oDioW DBExErLod6Ax2m8ynqiOGxaFqfKC56XkkdVLHvUCVJaAhFxgXjTUR6QAOQyv7wQ4UdEO i+r2MTY7DXFn8J2zKBJQQLtqa6Wlb7vKEWtzxWTyYG593uZ2vDKoLnibgmJamFh4xBvz Im2g== X-Gm-Message-State: APjAAAUnxBuqbbNTbrPXb8KfRAbzVRMpZi/ZXX2Imv5RS5Z6PUKHE+eN XQiBb+kg8MINAq7eLqEr0NU= X-Google-Smtp-Source: APXvYqwNS9DXB1+brvknJn9fv98cdddVBkIvLnD0BlX2eS57Oe+fV411xvfocIns/gXQOqKiybo5Rg== X-Received: by 2002:a7b:cb94:: with SMTP id m20mr2373088wmi.144.1560847980704; Tue, 18 Jun 2019 01:53:00 -0700 (PDT) Original-Received: from my-little-tumbleweed (71.142.13.109.rev.sfr.net. [109.13.142.71]) by smtp.gmail.com with ESMTPSA id g5sm15121962wrp.29.2019.06.18.01.52.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 01:52:59 -0700 (PDT) In-Reply-To: <85r27x2zrf.fsf@gmail.com> (npostavs@gmail.com's message of "Thu, 13 Jun 2019 12:53:08 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160761 Archived-At: npostavs@gmail.com writes: > (rx-to-string `(or (seq (or bos blank) > (group-n 1 ,char) > (or eos blank)) > (seq ?` (group-n 1 ,char) ?`))) Ah! Thanks for teaching me about \(?NUM: ... \), I did not know this Elisp extension. This makes the whole thing much more readable. For a minute I thought that maybe this patch should also add (require 'rx) somewhere in dired-aux.el, but AFAICT this is not necessary since rx-to-string is autoloaded=E2=80=A6 Do I understand correctly? Thanks again for the review, and for your efforts with bug#36237. (And thank you Stefan for your advice on being superstitious about the right things :) )