unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36741: 26.2.90; view-mode: Update docstring
@ 2019-07-20 13:45 Tino Calancha
  2019-07-25 13:50 ` Noam Postavsky
  0 siblings, 1 reply; 5+ messages in thread
From: Tino Calancha @ 2019-07-20 13:45 UTC (permalink / raw)
  To: 36741



The mention to kill buffers in this context is likely an original
implementation detail; nowadays, Emacs saves the killed text in variables.

Either way for the purpose to document this mode, the way how the text
is stored is not relevant.

--8<-----------------------------cut here---------------start------------->8---
From 54267d85f3418e0cb4cb1009fcd4e680bfda6825 Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Sat, 20 Jul 2019 15:23:38 +0200
Subject: [PATCH] * lisp/view.el (view-mode): Update docstring.

---
 lisp/view.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/view.el b/lisp/view.el
index 3d423f1748..5e6f3e2caa 100644
--- a/lisp/view.el
+++ b/lisp/view.el
@@ -386,8 +386,8 @@ view-mode
 if ARG is omitted or nil.
 
 When View mode is enabled, commands that do not change the buffer
-contents are available as usual.  Kill commands insert text in
-kill buffers but do not delete.  Most other commands beep and
+contents are available as usual.  Kill commands save text but
+do not delete it from the buffer.  Most other commands beep and
 tell the user that the buffer is read-only.
 
 \\<view-mode-map>
-- 
2.20.1

--8<-----------------------------cut here---------------end--------------->8---

In GNU Emacs 26.2.90 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
Repository revision: 021f32cca1b9082e7219b06aee28c00c4323a72a
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description:	Debian GNU/Linux 10 (buster)





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#36741: 26.2.90; view-mode: Update docstring
  2019-07-20 13:45 bug#36741: 26.2.90; view-mode: Update docstring Tino Calancha
@ 2019-07-25 13:50 ` Noam Postavsky
  2019-07-25 15:34   ` Tino Calancha
  0 siblings, 1 reply; 5+ messages in thread
From: Noam Postavsky @ 2019-07-25 13:50 UTC (permalink / raw)
  To: Tino Calancha; +Cc: 36741

Tino Calancha <tino.calancha@gmail.com> writes:

> The mention to kill buffers in this context is likely an original
> implementation detail; nowadays, Emacs saves the killed text in variables.

I think "kill buffers" is a typo for "kill ring".





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#36741: 26.2.90; view-mode: Update docstring
  2019-07-25 13:50 ` Noam Postavsky
@ 2019-07-25 15:34   ` Tino Calancha
  2019-07-25 16:51     ` Noam Postavsky
  0 siblings, 1 reply; 5+ messages in thread
From: Tino Calancha @ 2019-07-25 15:34 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: 36741, Tino Calancha



On Thu, 25 Jul 2019, Noam Postavsky wrote:
> I think "kill buffers" is a typo for "kill ring".

I think you are right.  I prefer to avoid saying "kill ring" because the 
sentence iw written in plural (kill commands); `kill-rectangle' won't
save the text in the kill ring by default.  It might confuse newbies.






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#36741: 26.2.90; view-mode: Update docstring
  2019-07-25 15:34   ` Tino Calancha
@ 2019-07-25 16:51     ` Noam Postavsky
  2019-07-26 15:42       ` Tino Calancha
  0 siblings, 1 reply; 5+ messages in thread
From: Noam Postavsky @ 2019-07-25 16:51 UTC (permalink / raw)
  To: Tino Calancha; +Cc: 36741

Tino Calancha <tino.calancha@gmail.com> writes:

> `kill-rectangle' won't save the text in the kill ring by default.

Ah good point, hadn't thought of that.  Then I think your patch is good,
you should push to emacs-26 (perhaps also mention the above point in the
commit message though).





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#36741: 26.2.90; view-mode: Update docstring
  2019-07-25 16:51     ` Noam Postavsky
@ 2019-07-26 15:42       ` Tino Calancha
  0 siblings, 0 replies; 5+ messages in thread
From: Tino Calancha @ 2019-07-26 15:42 UTC (permalink / raw)
  To: 36741-done



On Thu, 25 Jul 2019, Noam Postavsky wrote:

> Tino Calancha <tino.calancha@gmail.com> writes:
>> `kill-rectangle' won't save the text in the kill ring by default.
>
> I think your patch is good, you should push to emacs-26 (perhaps also 
> mention the above point in the  commit message though).

Pushed into emacs-26 branch with commit 'Update view-mode docstring'
(d4c49875eaae3078ea3b51cc7b72ae3403cb2c04)







^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-07-26 15:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-20 13:45 bug#36741: 26.2.90; view-mode: Update docstring Tino Calancha
2019-07-25 13:50 ` Noam Postavsky
2019-07-25 15:34   ` Tino Calancha
2019-07-25 16:51     ` Noam Postavsky
2019-07-26 15:42       ` Tino Calancha

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).