From: Noam Postavsky <npostavs@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: a_subscriber <a_subscriber@mail.ru>, 36871@debbugs.gnu.org
Subject: bug#36871: 26.1; I-search-toggle-csse-fold
Date: Sun, 04 Aug 2019 16:53:57 -0400 [thread overview]
Message-ID: <877e7sslcq.fsf@gmail.com> (raw)
In-Reply-To: <8736igslyx.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 04 Aug 2019 23:46:51 +0300")
Juri Linkov <juri@linkov.net> writes:
>> Shouldn't toggling commands activate isearch-mode?
>
> I meant the same guarding like in isearch-yank-kill:
> @@ -1971,6 +1971,7 @@ isearch-define-mode-toggle
> ,(format "Toggle %s searching on or off.%s" mode
> (if docstring (concat "\n" docstring) ""))
> (interactive)
> + (unless isearch-mode (isearch-mode t))
+1 from me, I like this better than throwing an error.
next prev parent reply other threads:[~2019-08-04 20:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 7:55 bug#36871: 26.1; I-search-toggle-csse-fold a_subscriber
2019-07-31 14:07 ` Eli Zaretskii
2019-07-31 14:11 ` Noam Postavsky
2019-07-31 14:56 ` Eli Zaretskii
2019-07-31 14:59 ` a_subscriber
2019-07-31 15:17 ` a_subscriber
2019-08-01 0:05 ` Noam Postavsky
2019-08-01 11:13 ` a_subscriber
2019-08-02 6:36 ` Eli Zaretskii
2019-08-03 2:54 ` Noam Postavsky
2019-08-03 7:00 ` Eli Zaretskii
2019-08-03 21:05 ` Juri Linkov
2019-08-04 20:46 ` Juri Linkov
2019-08-04 20:53 ` Noam Postavsky [this message]
2019-08-05 20:39 ` Juri Linkov
2019-07-31 15:34 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e7sslcq.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=36871@debbugs.gnu.org \
--cc=a_subscriber@mail.ru \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).