From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alex Branham <alex.branham@gmail.com>
Cc: 30235@debbugs.gnu.org, toby-undo-tree@dr-qubit.org
Subject: bug#30235: [patch] undo-tree byte-compiler warnings
Date: Tue, 17 Sep 2019 14:39:04 +0200 [thread overview]
Message-ID: <877e67m713.fsf@gnus.org> (raw)
In-Reply-To: <87y3ko9nbr.fsf@gmail.com> (Alex Branham's message of "Tue, 23 Jan 2018 17:18:00 -0600")
Alex Branham <alex.branham@gmail.com> writes:
> - (dotimes (i arg)
> + (dotimes (_i arg)
Jonas said:
> Toby, I am aware that I have suggested before that you use `_' as VAR in
> calls to `dotimes' instead of `i'. You rejected that suggestion,
> claiming that the byte-compiler complaining about `i' not being used is
> a bug.
While my preference is to avoid compiler warnings (because having a
warning-free build allows anybody working on the code to proceed with
greater speed and confidence), I think that for ELPA code this should be
up to the maintainer. Since it seems like Toby is opposed to these
changes, I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-09-17 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 23:18 bug#30235: [patch] undo-tree byte-compiler warnings Alex Branham
2019-06-25 11:51 ` bug#24354: " Lars Ingebrigtsen
2019-06-25 13:32 ` Basil L. Contovounesios
2019-06-25 13:34 ` Lars Ingebrigtsen
2019-06-26 3:24 ` bug#24354: " Richard Stallman
2019-09-17 12:39 ` Lars Ingebrigtsen [this message]
2019-09-18 11:51 ` Toby Cubitt
2019-09-18 13:53 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e67m713.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=30235@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=toby-undo-tree@dr-qubit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).