unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets <andreyk.mad@gmail.com>
Subject: bug#33740: [PATCH] Customizable flymake mode-line indicator
Date: Thu, 19 Sep 2019 17:39:38 +0200	[thread overview]
Message-ID: <877e64jnwl.fsf@gnus.org> (raw)
In-Reply-To: <CALDnm52nO3QQLJGRBJBPZcXR6nLH-EPDNzCxYSuxgjoybb1giQ@mail.gmail.com> ("João Távora"'s message of "Wed, 18 Sep 2019 14:59:08 +0100")

João Távora <joaotavora@gmail.com> writes:

>  Well, it doesn't quite work yet, so it's a bit premature.  :-)
>
> I see, what's wrong with it? 

I'm not sure -- there's something about the way Emacs renders the minor
mode lighters that doesn't quite preserve the text properties.  That'll
have to be fixed first...  if indeed that's the problem and I'm not just
doing something stupid here somehow.

> But flymake can work with annotations of arbitrary severities with some 
> user-specified meaning. Hence errors, warnings, notes etc are just
> annotations of severities 3, 2, 1, respectively. This was tied to 
> warning-numeric-level, which predates flymake.

Right, I see.  

> So I see "%e" as a shortcut for, say, "%3a" (number of annotations 
> of severity 3), which is no problem imo. "%na" is the thing that could
> be implemented later...

But the problem I see here is that the "unknown" annotations can't
really be specified in the format string and will therefore not be
shown.

If we have

(defvar flymake-mode-line-indicator-format " Flymake%s[%e %w %n]")

then we've enumerated all the annotations the user will ever see, and
new ones won't appear.

So I think specifying it on this detailed level isn't the path to go,
but instead we'll have

(defvar flymake-mode-line-indicator-format " Flymake%s[%a]")

where "%a" is "all the annotations".  I think that's flexible enough --
it doesn't allow the user to change the order of the annotations
individually, but I don't think that's really needed, either...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-09-19 15:39 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14  9:19 bug#33740: [PATCH] Customizable flymake mode-line indicator Andrii Kolomoiets
2019-01-04 20:27 ` João Távora
2019-06-22 14:15   ` Štěpán Němec
2019-09-16 22:22   ` Lars Ingebrigtsen
2019-09-17  6:09     ` Eli Zaretskii
2019-09-17 11:57       ` Lars Ingebrigtsen
2019-09-17 12:13         ` Eli Zaretskii
2019-09-17 12:22           ` Lars Ingebrigtsen
2019-09-17 12:44             ` Eli Zaretskii
2019-09-18 13:38               ` Lars Ingebrigtsen
2019-09-18 14:09                 ` Lars Ingebrigtsen
2019-09-19 15:28                   ` Lars Ingebrigtsen
2019-09-19 15:55                     ` Lars Ingebrigtsen
2019-09-19 16:23                       ` Lars Ingebrigtsen
2019-09-19 17:26                         ` Eli Zaretskii
2019-09-20 12:32                           ` Lars Ingebrigtsen
2019-09-20 13:06                             ` Eli Zaretskii
2019-09-20 13:13                               ` Lars Ingebrigtsen
2019-09-17 14:07     ` João Távora
2019-09-18 13:40       ` Lars Ingebrigtsen
2019-09-18 13:59         ` João Távora
2019-09-19 15:39           ` Lars Ingebrigtsen [this message]
2019-09-20 13:07             ` João Távora
2019-09-21  7:54               ` Lars Ingebrigtsen
2019-09-22 20:55                 ` Juri Linkov
2019-09-23  9:18                   ` João Távora
2019-09-23 18:10                     ` Lars Ingebrigtsen
2019-09-23  9:25                 ` João Távora
2019-09-23 18:11                   ` Lars Ingebrigtsen
2019-09-18 14:02         ` Noam Postavsky
2020-12-29  2:12   ` Lars Ingebrigtsen
2020-12-29  2:19     ` Lars Ingebrigtsen
2020-12-29 13:52       ` João Távora
2020-12-29 14:14         ` Lars Ingebrigtsen
2020-12-29 14:18       ` João Távora
2020-12-29 14:22         ` Lars Ingebrigtsen
2020-12-29 15:13           ` João Távora
2020-12-30  3:22             ` Lars Ingebrigtsen
2020-12-30  9:28               ` João Távora
2020-12-30 20:16                 ` Eli Zaretskii
2020-12-30 21:13                   ` João Távora
2020-12-31 14:05                     ` João Távora
2021-01-01 10:56                       ` Lars Ingebrigtsen
2021-01-02 11:27                         ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e64jnwl.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=33740@debbugs.gnu.org \
    --cc=andreyk.mad@gmail.com \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).