unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Samuel Bronson <naesten@gmail.com>, 17782@debbugs.gnu.org
Subject: bug#17782: 24.3; package.el: searches don't see elided chars of package name
Date: Mon, 07 Oct 2019 19:37:20 +0100	[thread overview]
Message-ID: <877e5gs8pr.fsf@tcd.ie> (raw)
In-Reply-To: <87d0f82zle.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 07 Oct 2019 20:13:33 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Samuel Bronson <naesten@gmail.com> writes:
>
>> When I search within the *Packages* buffer, my searches can't match on
>> parts of the package name that got elided to fit into the column width.
>>
>> Couldn't this be remedied by displaying the ellipsis using an overlay,
>> rather than actually including it in the buffer text?
>
> I've now done this in Emacs 27 -- in all tabulated list modes, which may
> or may not be controversial.
>
> If people feel like this is a bad change, feel free to revert.  It seems
> nice to me: `C-s' works more reliably in these buffers, even when bits
> are shortened.  But perhaps there's a bad user interaction somewhere...

I'm curious to know why the ellipsis is added as a display property in
truncate-string-to-width[1] instead of making the relevant text
invisible[2].  Isn't this behaviour too specific to this use case to
justify extending truncate-string-to-width with it?

[1]: Use text properties instead of truncating strings
67830e7569 2019-10-07 20:11:26 +0200
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=67830e756911f0c262bb3a447e58b9ff6739a60f

[2]: (info "(elisp) Invisible Text")

Thanks,

-- 
Basil





  parent reply	other threads:[~2019-10-07 18:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-14 20:58 bug#17782: 24.3; package.el: searches don't see elided chars of package name Samuel Bronson
2019-10-07 18:13 ` Lars Ingebrigtsen
2019-10-07 18:28   ` Stefan Kangas
2019-10-07 18:37   ` Basil L. Contovounesios [this message]
2019-10-08 16:14     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e5gs8pr.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=17782@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=naesten@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).