From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#37926: [PATCH] Unify Gnus select methods Date: Sat, 26 Oct 2019 13:21:27 -0700 Message-ID: <877e4r5kc8.fsf@ericabrahamsen.net> References: <87zhhoh9kn.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="132636"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37926@debbugs.gnu.org To: dick.r.chiang@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 26 22:22:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOSZn-000YKU-O4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Oct 2019 22:22:19 +0200 Original-Received: from localhost ([::1]:41968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOSZm-0000lx-8x for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Oct 2019 16:22:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54662) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOSZY-0000YA-VE for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 16:22:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOSZW-0005Au-Kh for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 16:22:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60882) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOSZW-0005Aq-Hf for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 16:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iOSZW-0008Ox-AF; Sat, 26 Oct 2019 16:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sat, 26 Oct 2019 20:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37926 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 37926-submit@debbugs.gnu.org id=B37926.157212129632236 (code B ref 37926); Sat, 26 Oct 2019 20:22:02 +0000 Original-Received: (at 37926) by debbugs.gnu.org; 26 Oct 2019 20:21:36 +0000 Original-Received: from localhost ([127.0.0.1]:41465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOSZ5-0008Ns-SJ for submit@debbugs.gnu.org; Sat, 26 Oct 2019 16:21:36 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:39432 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOSZ4-0008Nf-Cc for 37926@debbugs.gnu.org; Sat, 26 Oct 2019 16:21:35 -0400 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 8DDC3FA028; Sat, 26 Oct 2019 20:21:28 +0000 (UTC) In-Reply-To: <87zhhoh9kn.fsf@dick> (dick r. chiang's message of "Fri, 25 Oct 2019 16:08:40 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170220 Archived-At: dick.r.chiang@gmail.com writes: > From d4654ad8f3412c79fa7d29427e66d2b964d5e191 Mon Sep 17 00:00:00 2001 > From: dickmao > Date: Mon, 30 Sep 2019 09:13:38 -0400 > Subject: [PATCH] Unify gnus select methods into one defcustom This seems like a good idea in general. Gnus users are often unwilling to update their configs, but in this case I doubt anyone's really keen on retaining the primary/secondary distinction -- there's not much point to it. All the same, it's probably worth floating on gnus.general. My only note would be to add plenty of code comments (around the defcustoms) explaining what's going on here. I've considered making this change in the past, but it didn't quite seem worth it unless we could actually simplify the code -- doing away with gnus-select-method and gnus-secondary-select-methods altogether. In a way your patch sort of complicates things, in that a year from now a bug-hunter is going to have to familiarize themselves with the hows and whys of the relationship between those options and gnus-select-methods. In a codebase that already contains a lot of mystery, I think it's important to note explicitly what's been done. Thanks, Eric