From: Stefan Kangas <stefan@marxist.se>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 36603-done@debbugs.gnu.org
Subject: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Mon, 11 Nov 2019 19:44:29 +0100 [thread overview]
Message-ID: <877e46p81e.fsf@marxist.se> (raw)
In-Reply-To: <CADwFkm=qyHXTUK_ntPn7aY5i83nw7BARJCNye5bP9RvSS0SPuw@mail.gmail.com> (Stefan Kangas's message of "Tue, 20 Aug 2019 18:02:56 +0200")
Stefan Kangas <stefan@marxist.se> writes:
>> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
>> has describe_map start with a fresh seen pointer each time; but the
>> current code passes the same pointer to each describe_map call in a
>> loop.
>
> Thanks for that feedback. I'll take another look and get back to you.
I think your analysis is correct Noam, and I'm working on a different
approach here, although this project is has been put on the
back-burner for now. I'll get back into it once I can finish up some
other things first.
Thanks for taking the time to review this. Closing this bug report.
Best regards,
Stefan Kangas
prev parent reply other threads:[~2019-11-11 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 17:34 bug#36603: [PATCH] Simplify calling convention of describe_map Stefan Kangas
2019-07-11 17:37 ` Stefan Kangas
2019-08-20 15:32 ` Noam Postavsky
2019-08-20 16:00 ` Noam Postavsky
2019-08-20 16:02 ` Stefan Kangas
2019-11-11 18:44 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e46p81e.fsf@marxist.se \
--to=stefan@marxist.se \
--cc=36603-done@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).