From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38164: quit-restore-window doesn't restore point in man Date: Tue, 12 Nov 2019 22:50:12 +0200 Organization: LINKOV.NET Message-ID: <877e45ksaz.fsf@mail.linkov.net> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <87r3i9nped.fsf@gnus.org> <87wps1m7co.fsf@web.de> <87r22gbquk.fsf@mail.linkov.net> <875zjrzgoz.fsf_-_@mail.linkov.net> <02f0564a-baf3-b15c-bcc5-98d37f510d7a@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="158250"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 38164@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 12 22:11:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iUdRY-000f0p-DR for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Nov 2019 22:11:20 +0100 Original-Received: from localhost ([::1]:39570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUdRW-0001vm-SA for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Nov 2019 16:11:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59909) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUdRN-0001sQ-Dg for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2019 16:11:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUdRM-0006uQ-Az for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2019 16:11:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49673) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUdRM-0006uH-7w for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2019 16:11:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iUdRL-0002MS-0U for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2019 16:11:07 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Nov 2019 21:11:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38164 X-GNU-PR-Package: emacs Original-Received: via spool by 38164-submit@debbugs.gnu.org id=B38164.15735930448988 (code B ref 38164); Tue, 12 Nov 2019 21:11:06 +0000 Original-Received: (at 38164) by debbugs.gnu.org; 12 Nov 2019 21:10:44 +0000 Original-Received: from localhost ([127.0.0.1]:58484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUdQy-0002Kr-02 for submit@debbugs.gnu.org; Tue, 12 Nov 2019 16:10:44 -0500 Original-Received: from bird.elm.relay.mailchannels.net ([23.83.212.17]:51574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUdQw-0002Kj-49 for 38164@debbugs.gnu.org; Tue, 12 Nov 2019 16:10:42 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EFC745013A9; Tue, 12 Nov 2019 21:10:40 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com (100-96-60-110.trex.outbound.svc.cluster.local [100.96.60.110]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 85AB3500B11; Tue, 12 Nov 2019 21:10:40 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 12 Nov 2019 21:10:40 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Reaction-Troubled: 0184c2c24bfb239c_1573593040774_1491432859 X-MC-Loop-Signature: 1573593040774:3073854313 X-MC-Ingress-Time: 1573593040774 Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id 4E11A9D7B0; Tue, 12 Nov 2019 13:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=wVJeu1jBaJMgX9JiAfUVtQYimk4=; b= N0Sxp9c0UL46IPfjUhYL0LSCM+F2bNcRMy13es+L7EiFFdgUj94AV8YX7ZjgMkAM pg3hh7SJH1ubVzyRn3f6xUVQ+8tN0Sh2zZ0r34crpcYI90ck8SY4v7LUw8WaYum4 wnFnkg2sMd76UnNecElbuSlqJHrYMvGA8v+J82p9vnY= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 4B8F89D7C0; Tue, 12 Nov 2019 13:10:36 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a75 In-Reply-To: <02f0564a-baf3-b15c-bcc5-98d37f510d7a@gmx.at> (martin rudalics's message of "Mon, 11 Nov 2019 10:33:45 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171467 Archived-At: >>>> (progn >>>> (man "XYZ") >>>> (read-string "-->")) >>>> >>>> This is because quit-restore-window moves point to wrong window. >>> >>> What should 'quit-restore-window' do here in particular? >> >> quit-restore-window should move point to old-selected-window, >> i.e. the minibuffer window that was selected before Man-bgproc-sentinel >> kicked in. But I don't understand why it's not doing that. > > I'm not sure what you mean. At the time 'man' calls 'display-buffer', > the latter simply records the window returned by 'selected-window' as > the one to reselect when the *Man XYZ* window gets deleted. That > recorded window is not the minibuffer window here, even if I evaluate > the form via M-:. Am I missing something? Removing these lines from 'quit-restore-window' fixes the problem: ;; Select old window. (when (window-live-p (nth 2 quit-restore)) (select-window (nth 2 quit-restore))) If there lines are the whole purpose of 'quit-restore-window', then in man.el we need to reselect the original window explicitly: diff --git a/lisp/man.el b/lisp/man.el index ce01fdc805..76890f74a9 100644 --- a/lisp/man.el +++ b/lisp/man.el @@ -1469,8 +1469,10 @@ Man-bgproc-sentinel (when delete-buff (if (window-live-p (get-buffer-window Man-buffer t)) - (quit-restore-window - (get-buffer-window Man-buffer t) 'kill) + (progn + (quit-restore-window + (get-buffer-window Man-buffer t) 'kill) + (select-window (old-selected-window))) (kill-buffer Man-buffer))) (when message