unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Štěpán Němec" <stepnem@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
	35546@debbugs.gnu.org, Tassilo Horn <tsdh@gnu.org>
Subject: bug#35546: 27.0.50; setf return value for new alist entries is wrong
Date: Sun, 12 Apr 2020 14:47:24 +0200	[thread overview]
Message-ID: <877dykdg6b.fsf@gmail.com> (raw)
In-Reply-To: <875ze451dl.fsf@gmail.com> (Noam Postavsky's message of "Sun, 12 Apr 2020 08:34:14 -0400")

On Sun, 12 Apr 2020 08:34:14 -0400
Noam Postavsky wrote:

> Štěpán Němec <stepnem@gmail.com> writes:
>
>>                   (lambda (v)
>> +                   (macroexp-let2 nil v v
>
> Binding v to the value of v seems needlessly confusing.  How about
> renaming the lambda parameter to valexp or somthing like that?

I kind of agree, although really, I wish that would be the most
confusing part about gv.el. :-]

I did it like that because 1. this practice seems pretty common in Emacs
sources already, 2. it makes for the minimal change here.

I am certainly not against renaming the variable, though.

Thanks,

  Štěpán





  reply	other threads:[~2020-04-12 12:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 13:49 bug#35546: 27.0.50; setf return value for new alist entries is wrong Tassilo Horn
2019-05-07 11:19 ` Michael Heerdegen
2019-05-07 13:43   ` Michael Heerdegen
2019-05-07 14:58     ` npostavs
2019-05-07 15:56       ` Michael Heerdegen
2019-05-07 16:50         ` npostavs
2020-04-12 12:26           ` Štěpán Němec
2020-04-12 12:34             ` Noam Postavsky
2020-04-12 12:47               ` Štěpán Němec [this message]
2020-04-13  1:01                 ` Michael Heerdegen
2020-08-19 10:34                   ` Lars Ingebrigtsen
2020-08-25 16:16                     ` Štěpán Němec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dykdg6b.fsf@gmail.com \
    --to=stepnem@gmail.com \
    --cc=35546@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=npostavs@gmail.com \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).